[refactor]: Alternative method of address generation for Ledger (#901)

* [fix] Fixes the ledger live paths

* [refactor] Alternative way of generating addresses

* Removes unused deps

Author: taylorjdawson

package.json

@@ -2,7 +2,10 @@
   "name": "web3-onboard-monorepo",
   "private": true,
   "workspaces": [
-    "./packages/*"
+    "./packages/common",
+    "./packages/core",
+    "./packages/!(demo|core|common)/**",
+    "./packages/demo"
   ],
   "scripts": {
     "install-m1-mac": "yarn install --ignore-optional",

packages/ledger/package.json

@@ -30,8 +30,6 @@
     "@ledgerhq/hw-transport-webusb": "^6.19.0",
     "@metamask/eth-sig-util": "^4.0.0",
     "buffer": "^6.0.3",
-    "eth-crypto": "^2.1.0",
-    "ethereumjs-util": "^7.1.3",
-    "hdkey": "^2.0.1"
+    "ethereumjs-util": "^7.1.3"
   }
 }

packages/ledger/src/index.ts

@@ -14,6 +14,7 @@ import { Buffer } from 'buffer'
 
 import type Transport from '@ledgerhq/hw-transport'
 import type { providers } from 'ethers'
+import type Eth from '@ledgerhq/hw-app-eth'
 
 const LEDGER_LIVE_PATH = `m/44'/60'`
 const LEDGER_DEFAULT_PATH = `m/44'/60'/0'`
@@ -54,38 +55,20 @@ const getTransport = async () =>
     : (await import('@ledgerhq/hw-transport-u2f')).default
   ).create()
 
-interface LedgerAccount {
-  publicKey: string
-  derivationPath: string
-  chainCode: string
-}
-
 const getAccount = async (
-  { publicKey, chainCode, derivationPath }: LedgerAccount,
+  derivationPath: string,
   asset: Asset,
   index: number,
-  provider: providers.StaticJsonRpcProvider
+  provider: providers.StaticJsonRpcProvider,
+  eth: Eth
 ): Promise<Account> => {
-  //@ts-ignore
-  const { default: HDKey } = await import('hdkey')
-  const ethUtil = await import('ethereumjs-util')
-
-  // @ts-ignore - Commonjs importing weirdness
-  const { publicToAddress, toChecksumAddress } = ethUtil.default || ethUtil
-
-  const hdk = new HDKey()
-
-  hdk.publicKey = Buffer.from(publicKey, 'hex')
-  hdk.chainCode = Buffer.from(chainCode, 'hex')
-
-  const dkey = hdk.deriveChild(index)
-
-  const address = toChecksumAddress(
-    `0x${publicToAddress(dkey.publicKey, true).toString('hex')}`
-  )
-
+  const dPath =
+    derivationPath === LEDGER_LIVE_PATH
+      ? `${derivationPath}/${index}'/0/0`
+      : `${derivationPath}/${index}`
+  const { address } = await eth.getAddress(dPath)
   return {
-    derivationPath: `${derivationPath}/${index}`,
+    derivationPath: dPath,
     address,
     balance: {
       asset: asset.label,
@@ -95,9 +78,10 @@ const getAccount = async (
 }
 
 const getAddresses = async (
-  account: LedgerAccount,
+  derivationPath: string,
   asset: Asset,
-  provider: providers.StaticJsonRpcProvider
+  provider: providers.StaticJsonRpcProvider,
+  eth: Eth
 ): Promise<Account[]> => {
   const accounts = []
   let index = 0
@@ -106,7 +90,7 @@ const getAddresses = async (
   // Iterates until a 0 balance account is found
   // Then adds 4 more 0 balance accounts to the array
   while (zeroBalanceAccounts < 5) {
-    const acc = await getAccount(account, asset, index, provider)
+    const acc = await getAccount(derivationPath, asset, index, provider, eth)
     if (acc.balance.value.isZero()) {
       zeroBalanceAccounts++
       accounts.push(acc)
@@ -135,7 +119,6 @@ function ledger({
       getInterface: async ({ EventEmitter, chains }: GetInterfaceHelpers) => {
         const Eth = (await import('@ledgerhq/hw-app-eth')).default
         const { default: Common, Hardfork } = await import('@ethereumjs/common')
-        const { compress } = (await import('eth-crypto')).publicKey
         const ethUtil = await import('ethereumjs-util')
 
         const { SignTypedDataVersion } = await import('@metamask/eth-sig-util')
@@ -165,18 +148,13 @@ function ledger({
               chains.find(({ id }: Chain) => id === chainId) || currentChain
             const provider = new StaticJsonRpcProvider(currentChain.rpcUrl)
 
-            const { publicKey, chainCode, address } = await eth.getAddress(
-              derivationPath,
-              false,
-              true // set to true to return chainCode
-            )
-
             // Checks to see if this is a custom derivation path
             // If it is then just return the single account
             if (
               derivationPath !== LEDGER_LIVE_PATH &&
               derivationPath !== LEDGER_DEFAULT_PATH
             ) {
+              const { address } = await eth.getAddress(derivationPath)
               return [
                 {
                   derivationPath,
@@ -189,15 +167,7 @@ function ledger({
               ]
             }
 
-            return getAddresses(
-              {
-                publicKey: compress(publicKey),
-                chainCode: chainCode || '',
-                derivationPath
-              },
-              asset,
-              provider
-            )
+            return getAddresses(derivationPath, asset, provider, eth)
           } catch (error) {
             const { statusText } = error as { statusText: string }
             throw new Error(