Skip to content

Commit 2868c1b

Browse files
authored
Merge pull request #165 from blocknative/fix/cleanup-unused
Cleanup unused code. Closes #163
2 parents 821d337 + 10fb0bb commit 2868c1b

File tree

3 files changed

+7
-38
lines changed

3 files changed

+7
-38
lines changed

src/interfaces.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,3 @@ export interface AppState {
222222
export interface CancelablePromise extends Promise<any> {
223223
cancel: () => void
224224
}
225-
226-
export interface QueryablePromise extends CancelablePromise {
227-
isFulfilled: () => boolean
228-
isResolved: () => boolean
229-
isRejected: () => boolean
230-
}

src/stores.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { getBlocknative } from './services'
22
import { writable, derived, get } from 'svelte/store'
33
import debounce from 'lodash.debounce'
4-
import { wait, makeQueryablePromise, makeCancelable } from './utilities'
4+
import { wait, makeCancelable } from './utilities'
55
import { validateWalletInterface, validateType } from './validation'
66
import {
77
WritableStore,
@@ -10,7 +10,7 @@ import {
1010
WalletStateSliceStore,
1111
StateSyncer,
1212
BalanceStore,
13-
QueryablePromise
13+
CancelablePromise
1414
} from './interfaces'
1515

1616
export const app: WritableStore = writable({
@@ -28,7 +28,7 @@ export const app: WritableStore = writable({
2828
})
2929

3030
export const balanceSyncStatus: {
31-
syncing: null | QueryablePromise
31+
syncing: null | CancelablePromise
3232
error: string
3333
} = {
3434
syncing: null,
@@ -48,7 +48,8 @@ export const wallet: WritableStore = writable({
4848
name: null,
4949
provider: null,
5050
connect: null,
51-
instance: null
51+
instance: null,
52+
loading: null
5253
})
5354

5455
export const state = derived(

src/utilities.ts

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import bowser from 'bowser'
22
import BigNumber from 'bignumber.js'
33

4-
import { WalletInterface, QueryablePromise } from './interfaces'
4+
import { WalletInterface } from './interfaces'
55

66
export function getNetwork(provider: any): Promise<number | any> {
77
return new Promise((resolve, reject) => {
@@ -220,38 +220,12 @@ export function makeCancelable(promise: any) {
220220
})
221221

222222
wrappedPromise.cancel = () => {
223-
rejectFn('poop')
223+
rejectFn('canceled')
224224
}
225225

226226
return wrappedPromise
227227
}
228228

229-
export function makeQueryablePromise(promise: any): QueryablePromise {
230-
let isResolved = false
231-
let isRejected = false
232-
233-
promise.then(function(v: any) {
234-
isResolved = true
235-
return v
236-
})
237-
238-
promise.catch(() => {
239-
console.log('caught 2')
240-
isRejected = true
241-
})
242-
243-
promise.isFulfilled = function() {
244-
return isResolved || isRejected
245-
}
246-
promise.isResolved = function() {
247-
return isResolved
248-
}
249-
promise.isRejected = function() {
250-
return isRejected
251-
}
252-
return promise
253-
}
254-
255229
export function isPromise(val: any): val is Promise<any> {
256230
if ((val as Promise<any>) instanceof Promise) {
257231
return true

0 commit comments

Comments
 (0)