Silent op revert handling in Transaction.WaitForTransactionResult (#167)

Author: 0xFirekeeper

Assets/Thirdweb/Core/Scripts/AccountAbstraction/Core/SmartWallet.cs

@@ -331,21 +331,11 @@ private async Task<RpcResponseMessage> CreateUserOpAndSend(RpcRequestMessage req
             }
             ThirdwebDebug.Log("Tx Hash: " + txHash);
 
-            // Check if successful
+            // Check if successful deployment
 
             if (!_deployed)
             {
-                var receipt = await Transaction.WaitForTransactionResultRaw(txHash);
-                var decodedEvents = receipt.DecodeAllEvents<EntryPointContract.UserOperationEventEventDTO>();
-                if (decodedEvents[0].Event.Success == false)
-                {
-                    throw new Exception($"Transaction {txHash} execution reverted");
-                }
-                else
-                {
-                    ThirdwebDebug.Log("Transaction successful");
-                    _deployed = true;
-                }
+                await UpdateDeploymentStatus();
             }
 
             _deploying = false;

Assets/Thirdweb/Core/Scripts/Transaction.cs

@@ -8,6 +8,9 @@
 using MinimalForwarder = Thirdweb.Contracts.Forwarder.ContractDefinition;
 using UnityEngine.Networking;
 using Thirdweb.Redcode.Awaiting;
+using Nethereum.Contracts;
+using Nethereum.ABI.FunctionEncoding;
+using System;
 
 #pragma warning disable CS0618
 
@@ -407,8 +410,25 @@ public static async Task<TransactionReceipt> WaitForTransactionResultRaw(string
                 {
                     var reason = await web3.Eth.GetContractTransactionErrorReason.SendRequestAsync(txHash);
                     if (!string.IsNullOrEmpty(reason))
-                        throw new UnityException($"Transaction failed: {reason}");
+                        throw new UnityException($"Transaction {txHash} execution reverted: {reason}");
                 }
+
+                var userOpEvent = receipt.DecodeAllEvents<Thirdweb.Contracts.EntryPoint.ContractDefinition.UserOperationEventEventDTO>();
+                if (userOpEvent != null && userOpEvent.Count > 0 && userOpEvent[0].Event.Success == false)
+                {
+                    var revertReasonEvent = receipt.DecodeAllEvents<Thirdweb.Contracts.EntryPoint.ContractDefinition.UserOperationRevertReasonEventDTO>();
+                    if (revertReasonEvent != null && revertReasonEvent.Count > 0)
+                    {
+                        byte[] revertReason = revertReasonEvent[0].Event.RevertReason;
+                        string revertReasonString = new FunctionCallDecoder().DecodeFunctionErrorMessage(revertReason.ByteArrayToHexString());
+                        throw new Exception($"Transaction {txHash} execution silently reverted: {revertReasonString}");
+                    }
+                    else
+                    {
+                        throw new Exception($"Transaction {txHash} execution silently reverted with no reason string");
+                    }
+                }
+
                 return receipt;
             }
         }