[Update] Fix baseURI extraction logic and refactor lazy mint form (#4447)

FIXES: DASH-210

<!-- start pr-codex -->

## PR-Codex overview
The focus of this PR is to fix the baseURI extraction logic in the `lazy-mint-form.tsx` file.

### Detailed summary
- Removed unnecessary `upload` function calls for image and animation URLs
- Updated data processing logic in `LazyMintNftForm`
- Refactored `getBaseUriFromBatch` function for URI extraction
- Added tests for `getBaseUriFromBatch` function

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

Author: jnsdls

.changeset/flat-ads-look.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+fix baseURI extraction logic

apps/dashboard/src/contract-ui/tabs/nfts/components/lazy-mint-form.tsx

@@ -1,4 +1,3 @@
-import { thirdwebClient } from "@/constants/client";
 import {
   Accordion,
   AccordionButton,
@@ -28,7 +27,6 @@ import type { ThirdwebContract } from "thirdweb";
 import { lazyMint as lazyMint721 } from "thirdweb/extensions/erc721";
 import { lazyMint as lazyMint1155 } from "thirdweb/extensions/erc1155";
 import { useActiveAccount, useSendAndConfirmTransaction } from "thirdweb/react";
-import { upload } from "thirdweb/storage";
 import {
   Button,
   FormErrorMessage,
@@ -156,32 +154,13 @@ export const LazyMintNftForm: React.FC<LazyMintNftFormParams> = ({
               onError("Please connect your wallet to mint.");
               return;
             }
-            let imageUri = "";
-            if (data.image) {
-              imageUri = await upload({
-                client: thirdwebClient,
-                files: [data.image],
-              });
-            }
-            let animationUri = "";
-            if (data.animation_url) {
-              animationUri = await upload({
-                client: thirdwebClient,
-                files: [data.animation_url],
-              });
-            }
-            const dataWithCustom = {
-              ...data,
-              image: imageUri || data.customImage,
-              animation_url: animationUri || data.customAnimationUrl,
-            };
 
             trackEvent({
               category: "nft",
               action: "lazy-mint",
               label: "attempt",
             });
-            const nfts = [parseAttributes(dataWithCustom)];
+            const nfts = [parseAttributes(data)];
             const transaction = isErc721
               ? lazyMint721({ contract, nfts })
               : lazyMint1155({ contract, nfts });

packages/thirdweb/src/utils/ipfs.test.ts

@@ -1,6 +1,10 @@
 import { describe, expect, it } from "vitest";
 import { createThirdwebClient } from "../client/client.js";
-import { findIPFSCidFromUri, resolveScheme } from "./ipfs.js";
+import {
+  findIPFSCidFromUri,
+  getBaseUriFromBatch,
+  resolveScheme,
+} from "./ipfs.js";
 
 describe("resolveScheme", () => {
   it("should resolve ipfs scheme when not passing a gateway override", () => {
@@ -70,3 +74,55 @@ describe("resolveScheme", () => {
     expect(findIPFSCidFromUri(uri)).toBe(cid);
   });
 });
+
+describe("getBaseUriFromBatch", () => {
+  it("should return the base uri", () => {
+    const batchOfUris = ["ipfs://Qm.../0", "ipfs://Qm.../1", "ipfs://Qm.../2"];
+    const baseUri = getBaseUriFromBatch(batchOfUris);
+    expect(baseUri).toMatchInlineSnapshot(`"ipfs://Qm.../"`);
+  });
+  it("should throw if the batch is empty", () => {
+    expect(() => getBaseUriFromBatch([])).toThrowErrorMatchingInlineSnapshot(
+      "[Error: Batch of URIs is empty]",
+    );
+  });
+
+  it("should throw if an element of the array does not have the same base", () => {
+    const batchOfUris = ["ipfs://Qm.../0", "ipfs://Qm.../1", "ipfs://Qm2.../2"];
+    expect(() =>
+      getBaseUriFromBatch(batchOfUris),
+    ).toThrowErrorMatchingInlineSnapshot(
+      "[Error: All URIs in the batch must have the same base URI]",
+    );
+  });
+
+  it("should work with a custom domain", () => {
+    const batchOfUris = [
+      "https://example.com/0",
+      "https://example.com/1",
+      "https://example.com/2",
+    ];
+    const baseUri = getBaseUriFromBatch(batchOfUris);
+    expect(baseUri).toMatchInlineSnapshot(`"https://example.com/"`);
+  });
+
+  it("should work with a custom domain and path", () => {
+    const batchOfUris = [
+      "https://example.com/path/0",
+      "https://example.com/path/1",
+      "https://example.com/path/2",
+    ];
+    const baseUri = getBaseUriFromBatch(batchOfUris);
+    expect(baseUri).toMatchInlineSnapshot(`"https://example.com/path/"`);
+  });
+
+  it("should work with a custom domain and path with trailing slash", () => {
+    const batchOfUris = [
+      "https://example.com/path/0/",
+      "https://example.com/path/1/",
+      "https://example.com/path/2/",
+    ];
+    const baseUri = getBaseUriFromBatch(batchOfUris);
+    expect(baseUri).toMatchInlineSnapshot(`"https://example.com/path/"`);
+  });
+});

packages/thirdweb/src/utils/ipfs.ts

@@ -1,5 +1,4 @@
 import type { ThirdwebClient } from "../client/client.js";
-
 import type { FileOrBufferOrString } from "../storage/upload/types.js";
 
 export type ResolveSchemeOptions = {
@@ -109,23 +108,32 @@ export async function uploadOrExtractURIs<
  * @internal
  */
 export function getBaseUriFromBatch(uris: string[]): string {
-  const urisWithSlashes = uris.map((uri) => new URL(uri));
-  const baseUri = urisWithSlashes[0];
-  for (let i = 0; i < urisWithSlashes.length; i++) {
-    const uri = urisWithSlashes[i];
-    if (baseUri?.host !== uri?.host) {
-      throw new Error(
-        `Can only create batches with the same base URI for every entry in the batch. Expected '${baseUri}' but got '${uri}'`,
-      );
+  const [base, ...rest] = uris.map((uri) => {
+    // remove query parameters
+    // biome-ignore lint/style/noParameterAssign: lemme do my stuff
+    [uri] = uri.split("?") as [string];
+    // remove fragments
+    // biome-ignore lint/style/noParameterAssign: lemme do my stuff
+    [uri] = uri.split("#") as [string];
+
+    // if the URI ends with a `/`, remove it
+    if (uri.endsWith("/")) {
+      // biome-ignore lint/style/noParameterAssign: lemme do my stuff
+      uri = uri.slice(0, -1);
     }
-  }
 
-  if (!baseUri) {
-    throw new Error("No base URI found in the batch");
+    // remove the last part of the URI & add the trailing `/`
+    return `${uri.split("/").slice(0, -1).join("/")}/`;
+  });
+
+  if (!base) {
+    throw new Error("Batch of URIs is empty");
   }
 
-  // Ensure that baseUri ends with trailing slash
-  return `${baseUri.protocol}//${baseUri.host}/`;
+  if (rest.some((uri) => uri !== base)) {
+    throw new Error("All URIs in the batch must have the same base URI");
+  }
+  return base;
 }
 
 function isUriList<T extends FileOrBufferOrString | Record<string, unknown>>(