Skip to content

Commit ea3c702

Browse files
committed
Fix lint errors (#7401)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `sidebar.tsx` file by modifying the `href` property of a menu item and enhancing `globals.css` to improve code styling, particularly for code spans in both light and dark themes. ### Detailed summary - In `sidebar.tsx`, the `href` property for the menu item "Get Dedicated Support" was removed. - In `globals.css`, new styles were added for `code span` to set colors for light and dark themes. - Redundant `.shiki` styles were removed. - Existing styles for autofilled inputs and button elements remain unchanged. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Consolidated and reorganized CSS rules for code highlighting to improve maintainability. No visual changes were made. - **Refactor** - Adjusted the order of properties within the sidebar configuration for improved code consistency. No changes to functionality or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 51798f0 commit ea3c702

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

apps/portal/src/app/account/sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ export const sidebar: SideBar = {
3232
name: "Manage Billing",
3333
},
3434
{
35-
name: "Get Dedicated Support",
3635
href: `${accountSlug}/teams/get-dedicated-support`,
36+
name: "Get Dedicated Support",
3737
},
3838
],
3939
name: "Teams",

apps/portal/src/app/globals.css

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,19 @@
108108
}
109109
}
110110

111+
code span {
112+
color: var(--code-light-color);
113+
}
114+
115+
.dark code span {
116+
color: var(--code-dark-color);
117+
}
118+
119+
.shiki,
120+
.shiki span {
121+
background-color: transparent !important;
122+
}
123+
111124
.dark .shiki,
112125
.dark .shiki span {
113126
color: var(--shiki-dark) !important;
@@ -117,11 +130,6 @@
117130
text-decoration: var(--shiki-dark-text-decoration) !important;
118131
}
119132

120-
.shiki,
121-
.shiki span {
122-
background-color: transparent !important;
123-
}
124-
125133
/* Fix colors on auto-filled inputs */
126134
input:-webkit-autofill,
127135
input:-webkit-autofill:hover,
@@ -192,13 +200,3 @@ button {
192200
html:not(.dark) .dark-only {
193201
display: none;
194202
}
195-
196-
/* biome-ignore lint/style/noDescendingSpecificity:we explicitly WANT to target SPANs INSIDE of CODE tags */
197-
code span {
198-
color: var(--code-light-color);
199-
}
200-
201-
/* biome-ignore lint/style/noDescendingSpecificity:we explicitly WANT to target SPANs INSIDE of CODE tags */
202-
.dark code span {
203-
color: var(--code-dark-color);
204-
}

0 commit comments

Comments
 (0)