Skip to content

Commit e3c0af2

Browse files
committed
[SDK] Fix: Track chain ID on transaction events (#5272)
Fixes [CNCT-2184](https://linear.app/thirdweb/issue/CNCT-2184) <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces modifications to the `trackTransaction` function across multiple files in the `thirdweb` package, adding support for `chainId` in transaction tracking. ### Detailed summary - Added `chainId: tx.chainId` to `trackTransaction` in: - `packages/thirdweb/src/wallets/injected/index.ts` - `packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts` - `packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts` - `packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts` - `packages/thirdweb/src/wallets/wallet-connect/controller.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
1 parent 6679888 commit e3c0af2

File tree

6 files changed

+10
-0
lines changed

6 files changed

+10
-0
lines changed

.changeset/honest-papayas-remember.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"thirdweb": patch
3+
---
4+
5+
Tracks transaction chain IDs

packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@ function createAccount({
307307

308308
trackTransaction({
309309
client: client,
310+
chainId: tx.chainId,
310311
walletAddress: getAddress(address),
311312
walletType: COINBASE,
312313
transactionHash,

packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ export class EnclaveWallet implements IWebWallet {
202202
trackTransaction({
203203
client,
204204
ecosystem,
205+
chainId: tx.chainId,
205206
walletAddress: address,
206207
walletType: "inApp",
207208
transactionHash,

packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ export class IFrameWallet implements IWebWallet {
251251

252252
trackTransaction({
253253
client,
254+
chainId: tx.chainId,
254255
walletAddress: address,
255256
walletType: "inApp",
256257
transactionHash,

packages/thirdweb/src/wallets/injected/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ function createAccount({
162162

163163
trackTransaction({
164164
client,
165+
chainId: tx.chainId,
165166
walletAddress: getAddress(address),
166167
walletType: id,
167168
transactionHash,

packages/thirdweb/src/wallets/wallet-connect/controller.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@ function createAccount({
351351
walletAddress: getAddress(address),
352352
walletType: "walletConnect",
353353
transactionHash,
354+
chainId: tx.chainId,
354355
contractAddress: tx.to ?? undefined,
355356
gasPrice: tx.gasPrice,
356357
});

0 commit comments

Comments
 (0)