Skip to content

Commit e1f73c8

Browse files
[SDK] chore: Re-enable flaky smart wallet tests (#6369)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on addressing flaky tests in the `thirdweb` codebase by enabling previously skipped tests related to `SmartWallet` functionality, ensuring they are executed as part of the test suite. ### Detailed summary - Removed `.github/workflows/issue.yml`. - Enabled `describe` and `test` blocks previously marked as skipped in: - `smart-wallet-modular.test.ts` - `verify-typed-data.test.ts` - `smart-wallet-integration-v07.test.ts` - Adjusted test configurations by removing `FIMXE` comments and retry limits. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
1 parent c4e7f3b commit e1f73c8

File tree

5 files changed

+6
-63
lines changed

5 files changed

+6
-63
lines changed

.github/workflows/issue.yml

Lines changed: 0 additions & 49 deletions
This file was deleted.

packages/thirdweb/src/auth/verify-typed-data.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("verifyTypedData", async () => {
2626
).toBe(true);
2727
});
2828

29-
// FIXME: flaky test - needs to be fixed
30-
test.skip("invalid EOA signature", async () => {
29+
test("invalid EOA signature", async () => {
3130
expect(
3231
await verifyTypedData({
3332
...typedData.basic,
@@ -54,8 +53,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("verifyTypedData", async () => {
5453
).toBe(true);
5554
});
5655

57-
// FIXME: flaky test - needs to be fixed
58-
test.skip("invalid smart account signature", async () => {
56+
test("invalid smart account signature", async () => {
5957
expect(
6058
await verifyTypedData({
6159
...typedData.basic,

packages/thirdweb/src/wallets/smart/smart-wallet-integration-v07.test.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,9 @@ const contract = getContract({
4949
address: "0xe2cb0eb5147b42095c2FfA6F7ec953bb0bE347D8",
5050
});
5151

52-
// FIXME: SKIP ALL OF THIS IT IS FLAKY
53-
describe.skip(
52+
describe.sequential(
5453
"SmartWallet 0.7 core tests",
5554
{
56-
retry: 0,
5755
timeout: 240_000,
5856
},
5957
() => {
@@ -103,8 +101,7 @@ describe.skip(
103101
expect(isValid).toEqual(true);
104102
});
105103

106-
// FIXME: flaky test - skipped
107-
it.skip("should use ERC-1271 signatures after deployment", async () => {
104+
it("should use ERC-1271 signatures after deployment", async () => {
108105
await deploySmartAccount({
109106
chain,
110107
client,
@@ -137,8 +134,7 @@ describe.skip(
137134
expect(isValid).toEqual(true);
138135
});
139136

140-
// FIXME: flaky test - skipped
141-
it.skip("should use ERC-1271 typed data signatures after deployment", async () => {
137+
it("should use ERC-1271 typed data signatures after deployment", async () => {
142138
await deploySmartAccount({
143139
chain,
144140
client,

packages/thirdweb/src/wallets/smart/smart-wallet-integration.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ const factoryAddress = "0x564cf6453a1b0FF8DB603E92EA4BbD410dea45F3"; // pre 712
5151
describe.runIf(process.env.TW_SECRET_KEY).sequential(
5252
"SmartWallet core tests",
5353
{
54-
retry: 0,
5554
timeout: 240_000,
5655
},
5756
() => {

packages/thirdweb/src/wallets/smart/smart-wallet-modular.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ const client = TEST_CLIENT;
2828
const DEFAULT_FACTORY_ADDRESS = "0xB1846E893CA01c5Dcdaa40371C1e13f2e0Df5717";
2929
const DEFAULT_VALIDATOR_ADDRESS = "0x7D3631d823e0De311DC86f580946EeF2eEC81fba";
3030

31-
// FIXME: This test is flaky and needs to be fixed
32-
describe.skip.sequential(
31+
describe.sequential(
3332
"SmartWallet modular tests",
3433
{
3534
retry: 0,

0 commit comments

Comments
 (0)