chore: Simplify HTTP logs (#2530)

Author: arcoraven

packages/service-utils/src/cf-worker/index.ts

@@ -175,14 +175,14 @@ function bufferToHex(buffer: ArrayBuffer) {
 }
 
 export async function logHttpRequest({
-  source,
   clientId,
   req,
   res,
   isAuthed,
   statusMessage,
   latencyMs,
 }: AuthInput & {
+  // @deprecated
   source: string;
   res: Response;
   isAuthed?: boolean;
@@ -195,23 +195,23 @@ export async function logHttpRequest({
 
     console.log(
       JSON.stringify({
-        source,
+        method: req.method,
         pathname: req.url,
         hasSecretKey: !!authorizationData.secretKey,
         hasClientId: !!authorizationData.clientId,
         hasJwt: !!authorizationData.jwt,
         clientId: authorizationData.clientId,
-        isAuthed: !!isAuthed ?? null,
+        isAuthed,
         status: res.status,
-        sdkName: headers.get("x-sdk-name") ?? "unknown",
-        sdkVersion: headers.get("x-sdk-version") ?? "unknown",
-        platform: headers.get("x-sdk-platform") ?? "unknown",
-        os: headers.get("x-sdk-os") ?? "unknown",
-        latencyMs: latencyMs ?? null,
+        sdkName: headers.get("x-sdk-name") ?? undefined,
+        sdkVersion: headers.get("x-sdk-version") ?? undefined,
+        platform: headers.get("x-sdk-platform") ?? undefined,
+        os: headers.get("x-sdk-os") ?? undefined,
+        latencyMs,
       }),
     );
-    console.log(`statusMessage=${statusMessage ?? res.statusText}`);
-  } catch (err) {
-    console.error("Failed to log HTTP request:", err);
-  }
+    if (statusMessage) {
+      console.log(`statusMessage=${statusMessage}`);
+    }
+  } catch (err) {}
 }

packages/service-utils/src/node/index.ts

@@ -177,14 +177,14 @@ export function deriveClientIdFromSecretKeyHash(secretKeyHash: string) {
 }
 
 export function logHttpRequest({
-  source,
   clientId,
   req,
   res,
   isAuthed,
   statusMessage,
   latencyMs,
 }: AuthInput & {
+  // @deprecated
   source: string;
   res: ServerResponse;
   isAuthed?: boolean;
@@ -195,27 +195,23 @@ export function logHttpRequest({
     const authorizationData = extractAuthorizationData({ req, clientId });
     const headers = req.headers;
 
-    const _statusMessage = statusMessage ?? res.statusMessage;
     console.log(
       JSON.stringify({
-        source,
+        method: req.method,
         pathname: req.url,
         hasSecretKey: !!authorizationData.secretKey,
         hasClientId: !!authorizationData.clientId,
         hasJwt: !!authorizationData.jwt,
         clientId: authorizationData.clientId,
-        isAuthed: !!isAuthed ?? null,
+        isAuthed,
         status: res.statusCode,
-        statusMessage: _statusMessage,
-        sdkName: headers["x-sdk-name"] ?? "unknown",
-        sdkVersion: headers["x-sdk-version"] ?? "unknown",
-        platform: headers["x-sdk-platform"] ?? "unknown",
-        os: headers["x-sdk-os"] ?? "unknown",
-        latencyMs: latencyMs ?? null,
+        statusMessage,
+        sdkName: headers["x-sdk-name"] ?? undefined,
+        sdkVersion: headers["x-sdk-version"] ?? undefined,
+        platform: headers["x-sdk-platform"] ?? undefined,
+        os: headers["x-sdk-os"] ?? undefined,
+        latencyMs,
       }),
     );
-    console.log(`statusMessage=${_statusMessage}`);
-  } catch (err) {
-    console.error("Failed to log HTTP request:", err);
-  }
+  } catch (err) {}
 }