fix: overestimate zksync gas limit for paymaster extra gas (#4979)

Author: joaquim-verges

.changeset/nasty-experts-whisper.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Overestimate zksync gas limit to account for paymaster extra gas

packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.ts

@@ -128,7 +128,7 @@ export async function populateEip712Transaction(
       max_priority_fee_per_gas: string;
       gas_per_pubdata_limit: string;
     };
-    gas = toBigInt(result.gas_limit);
+    gas = toBigInt(result.gas_limit) * 2n; // overestimating to avoid issues when not accounting for paymaster extra gas ( we should really pass the paymaster input above for better accuracy )
     const baseFee = toBigInt(result.max_fee_per_gas);
     maxFeePerGas = baseFee * 2n; // bumping the base fee per gas to ensure fast inclusion
     maxPriorityFeePerGas = toBigInt(result.max_priority_fee_per_gas) || 1n;

packages/thirdweb/src/wallets/smart/smart-wallet-zksync.test.ts

@@ -64,6 +64,18 @@ describe.runIf(process.env.TW_SECRET_KEY).todo(
       expect(tx.transactionHash.length).toBe(66);
     });
 
+    it("should send dummy a transactions", async () => {
+      const tx = await sendAndConfirmTransaction({
+        transaction: prepareTransaction({
+          chain,
+          client,
+          to: "0x611e71B12a2B1C0c884574042414Fe360aF0C5A7",
+        }),
+        account: smartAccount,
+      });
+      expect(tx.transactionHash.length).toBe(66);
+    });
+
     it.skip("should send a transaction on zkcandy", async () => {
       const zkCandy = defineChain(302);
       const zkCandySmartWallet = smartWallet({