Skip to content

Commit c55f02f

Browse files
committed
fix: should always contain gas price info even if it's 0 (#5673)
https://linear.app/thirdweb/issue/CNCT-2602/issue-signing-deploy-tx-on-saakura <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on ensuring that gas price information is always included for enclave wallets, even when it is 0. It modifies the condition for setting the `maxFeePerGas` to check for the type `bigint`. ### Detailed summary - Updated the condition to check if `tx.maxFeePerGas` is of type `bigint`. - Ensured that `transaction.maxFeePerGas` is set correctly when `tx.maxFeePerGas` is provided. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
1 parent e702490 commit c55f02f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.changeset/nervous-pots-smell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"thirdweb": patch
3+
---
4+
5+
always include gas price information even if it's 0 for enclave wallets

packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export class EnclaveWallet implements IWebWallet {
162162
chainId: toHex(tx.chainId),
163163
};
164164

165-
if (tx.maxFeePerGas) {
165+
if (typeof tx.maxFeePerGas === "bigint") {
166166
transaction.maxFeePerGas = toHex(tx.maxFeePerGas);
167167
transaction.maxPriorityFeePerGas =
168168
typeof tx.maxPriorityFeePerGas === "bigint"

0 commit comments

Comments
 (0)