[SDK] Avoid IPFS uploads in tests whenever possible (#4824)

Author: kien-ngo

packages/thirdweb/src/extensions/erc1155/drop1155.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { VITALIK_WALLET } from "../../../test/src/addresses.js";
 import { ANVIL_CHAIN } from "../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../test/src/test-clients.js";
@@ -11,7 +12,6 @@ import { type ThirdwebContract, getContract } from "../../contract/contract.js";
 import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js";
 import { resolvePromisedValue } from "../../utils/promise/resolve-promised-value.js";
 import { toEther } from "../../utils/units.js";
-import { getContractMetadata } from "../common/read/getContractMetadata.js";
 import { deployERC1155Contract } from "../prebuilts/deploy-erc1155.js";
 import { balanceOf } from "./__generated__/IERC1155/read/balanceOf.js";
 import { nextTokenIdToMint } from "./__generated__/IERC1155Enumerable/read/nextTokenIdToMint.js";
@@ -37,6 +37,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
         client: TEST_CLIENT,
         params: {
           name: "Test DropERC1155",
+          contractURI: TEST_CONTRACT_URI,
         },
         type: "DropERC1155",
       });
@@ -49,16 +50,6 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       // this deploys a contract, it may take some time
     }, 60_000);
 
-    describe("Deployment", () => {
-      it("should deploy", async () => {
-        expect(contract).toBeDefined();
-      });
-      it("should have the correct name", async () => {
-        const metadata = await getContractMetadata({ contract });
-        expect(metadata.name).toBe("Test DropERC1155");
-      });
-    });
-
     it("should allow for lazy minting tokens", async () => {
       const mintTx = lazyMint({
         contract,

packages/thirdweb/src/extensions/erc1155/token1155.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../test/src/test-clients.js";
 import {
@@ -7,7 +8,6 @@ import {
 } from "../../../test/src/test-wallets.js";
 import { type ThirdwebContract, getContract } from "../../contract/contract.js";
 import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js";
-import { getContractMetadata } from "../common/read/getContractMetadata.js";
 import { deployERC1155Contract } from "../prebuilts/deploy-erc1155.js";
 import { balanceOf } from "./__generated__/IERC1155/read/balanceOf.js";
 import { totalSupply } from "./__generated__/IERC1155/read/totalSupply.js";
@@ -27,6 +27,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("TokenERC1155", () => {
       client: TEST_CLIENT,
       params: {
         name: "Test TokenERC1155",
+        contractURI: TEST_CONTRACT_URI,
       },
       type: "TokenERC1155",
     });
@@ -39,16 +40,6 @@ describe.runIf(process.env.TW_SECRET_KEY)("TokenERC1155", () => {
     // this deploys a contract, it may take some time
   }, 60_000);
 
-  describe("Deployment", () => {
-    it("should deploy", async () => {
-      expect(contract).toBeDefined();
-    });
-    it("should have the correct name", async () => {
-      const metadata = await getContractMetadata({ contract });
-      expect(metadata.name).toBe("Test TokenERC1155");
-    });
-  });
-
   it("should allow for minting tokens", async () => {
     // initially no tokens minted
     await expect(nextTokenIdToMint({ contract })).resolves.toBe(0n);

packages/thirdweb/src/extensions/erc20/drop20.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { VITALIK_WALLET } from "../../../test/src/addresses.js";
 import { ANVIL_CHAIN } from "../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../test/src/test-clients.js";
@@ -12,7 +13,6 @@ import { type ThirdwebContract, getContract } from "../../contract/contract.js";
 import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js";
 import { resolvePromisedValue } from "../../utils/promise/resolve-promised-value.js";
 import { toEther } from "../../utils/units.js";
-import { getContractMetadata } from "../common/read/getContractMetadata.js";
 import { deployERC20Contract } from "../prebuilts/deploy-erc20.js";
 import { getClaimConditions } from "./drops/read/getClaimConditions.js";
 import { claimTo } from "./drops/write/claimTo.js";
@@ -35,6 +35,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
         client: TEST_CLIENT,
         params: {
           name: "Test DropERC20",
+          contractURI: TEST_CONTRACT_URI,
         },
         type: "DropERC20",
       });
@@ -47,16 +48,6 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       // this deploys a contract, it may take some time
     }, 60_000);
 
-    describe("Deployment", () => {
-      it("should deploy", async () => {
-        expect(contract).toBeDefined();
-      });
-      it("should have the correct name", async () => {
-        const metadata = await getContractMetadata({ contract });
-        expect(metadata.name).toBe("Test DropERC20");
-      });
-    });
-
     it("should allow to claim tokens", async () => {
       await expect(
         getBalance({ contract, address: TEST_ACCOUNT_A.address }),

packages/thirdweb/src/extensions/erc721/drop721.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { VITALIK_WALLET } from "../../../test/src/addresses.js";
 import { ANVIL_CHAIN } from "../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../test/src/test-clients.js";
@@ -12,7 +13,6 @@ import { type ThirdwebContract, getContract } from "../../contract/contract.js";
 import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js";
 import { resolvePromisedValue } from "../../utils/promise/resolve-promised-value.js";
 import { toEther } from "../../utils/units.js";
-import { getContractMetadata } from "../common/read/getContractMetadata.js";
 import { deployERC20Contract } from "../prebuilts/deploy-erc20.js";
 import { deployERC721Contract } from "../prebuilts/deploy-erc721.js";
 import { balanceOf } from "./__generated__/IERC721A/read/balanceOf.js";
@@ -40,6 +40,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
         client: TEST_CLIENT,
         params: {
           name: "Test DropERC721",
+          contractURI: TEST_CONTRACT_URI,
         },
         type: "DropERC721",
       });
@@ -50,6 +51,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
         client: TEST_CLIENT,
         params: {
           name: "Test ERC20",
+          contractURI: TEST_CONTRACT_URI,
         },
         type: "TokenERC20",
       });
@@ -68,16 +70,6 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       // this deploys a contract, it may take some time
     }, 120_000);
 
-    describe("Deployment", () => {
-      it("should deploy", async () => {
-        expect(contract).toBeDefined();
-      });
-      it("should have the correct name", async () => {
-        const metadata = await getContractMetadata({ contract });
-        expect(metadata.name).toBe("Test DropERC721");
-      });
-    });
-
     it("should allow for lazy minting tokens", async () => {
       const mintTx = lazyMint({
         contract,

packages/thirdweb/src/extensions/erc721/lazyMinting/write/createAndReveal.test.ts

@@ -1,5 +1,6 @@
 import { beforeAll, describe, it } from "vitest";
 import { expect } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../../../test/src/test-clients.js";
 import { TEST_ACCOUNT_A } from "../../../../../test/src/test-wallets.js";
@@ -39,8 +40,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("createAndReveal", () => {
       type: "DropERC721",
       params: {
         name: "Test NFT",
-        description: "Test NFT Description",
-        contractURI: "",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
     contract = getContract({

packages/thirdweb/src/extensions/erc721/write/mintTo.test.ts

@@ -3,6 +3,7 @@ import { ANVIL_CHAIN } from "~test/chains.js";
 import { TEST_CLIENT } from "~test/test-clients.js";
 import { TEST_ACCOUNT_A } from "~test/test-wallets.js";
 
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import {
   type ThirdwebContract,
   getContract,
@@ -27,6 +28,7 @@ describe.runIf(!!process.env.TW_SECRET_KEY)("erc721 mintTo extension", () => {
       type: "TokenERC721",
       params: {
         name: "NFTDrop",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
     contract = getContract({

packages/thirdweb/src/extensions/marketplace/english-auctions/english-auctions.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../../test/src/test-clients.js";
 import {
@@ -37,6 +38,7 @@ describe.skip("Marketplace: English Auctions", () => {
       client: TEST_CLIENT,
       params: {
         name: "TestMarketPlace",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
     marketplaceContract = getContract({
@@ -53,6 +55,7 @@ describe.skip("Marketplace: English Auctions", () => {
       client: TEST_CLIENT,
       params: {
         name: "TestERC721",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
 

packages/thirdweb/src/extensions/marketplace/offers/offers.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../../test/src/test-clients.js";
 import {
@@ -43,6 +44,7 @@ describe.skip("Marketplace: Offers", () => {
       client: TEST_CLIENT,
       params: {
         name: "TestMarketPlace",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
     marketplaceContract = getContract({
@@ -59,6 +61,7 @@ describe.skip("Marketplace: Offers", () => {
       client: TEST_CLIENT,
       params: {
         name: "TestERC721",
+        contractURI: TEST_CONTRACT_URI,
       },
     });
 

packages/thirdweb/src/extensions/modules/ClaimableERC1155/claimableERC1155.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../../test/src/test-clients.js";
 import {
@@ -29,7 +30,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("ModularClaimableERC1155", () => {
       core: "ERC1155",
       params: {
         name: "TestDropERC1155",
-        symbol: "TT",
+        contractURI: TEST_CONTRACT_URI,
       },
       modules: [
         ClaimableERC1155.module({

packages/thirdweb/src/extensions/modules/ClaimableERC20/claimableERC20.test.ts

@@ -1,4 +1,5 @@
 import { beforeAll, describe, expect, it } from "vitest";
+import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js";
 import { ANVIL_CHAIN } from "../../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../../test/src/test-clients.js";
 import {
@@ -26,7 +27,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("ModularDropERC20", () => {
       core: "ERC20",
       params: {
         name: "TestDropERC20",
-        symbol: "TT",
+        contractURI: TEST_CONTRACT_URI,
       },
       modules: [
         ClaimableERC20.module({