Skip to content

Commit 6235fe7

Browse files
[SDK] fix: Initialize wallet connection status as unknown (#6360)
1 parent d8e9245 commit 6235fe7

File tree

5 files changed

+21
-10
lines changed

5 files changed

+21
-10
lines changed

.changeset/grumpy-vans-rhyme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"thirdweb": patch
3+
---
4+
5+
Initialize activeWalletConnectionStatus as 'unknown' instead of 'disconnected'

packages/thirdweb/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,10 @@
316316
"clean": "rimraf dist",
317317
"size": "size-limit",
318318
"test:watch": "vitest -c ./test/vitest.config.ts dev",
319-
"test": "vitest run -c ./test/vitest.config.ts --coverage",
320-
"test:cov": "vitest dev -c ./test/vitest.config.ts --coverage",
321-
"test:ui": "vitest dev -c ./test/vitest.config.ts --coverage --ui",
322-
"test:dev": "vitest run -c ./test/vitest.config.ts",
319+
"test": "NODE_OPTIONS=--max-old-space-size=8192 vitest run -c ./test/vitest.config.ts --coverage",
320+
"test:cov": "NODE_OPTIONS=--max-old-space-size=8192 vitest dev -c ./test/vitest.config.ts --coverage",
321+
"test:ui": "NODE_OPTIONS=--max-old-space-size=8192 vitest dev -c ./test/vitest.config.ts --coverage --ui",
322+
"test:dev": "NODE_OPTIONS=--max-old-space-size=8192 vitest run -c ./test/vitest.config.ts",
323323
"test:react": "vitest run -c ./test/vitest.config.ts dev --ui src/react",
324324
"typedoc": "node scripts/typedoc.mjs && node scripts/parse.mjs",
325325
"update-version": "node scripts/version.mjs",

packages/thirdweb/src/react/core/hooks/wallets/useConnect.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe("useAddConnectedWallet", () => {
4848
},
4949
);
5050
const { result } = renderHook(() => useConnect(), { wrapper });
51-
expect(statusResult.current).toEqual("disconnected");
51+
expect(statusResult.current).toEqual("unknown");
5252
await result.current.connect(async () => wallet);
5353
expect(statusResult.current).toEqual("connected");
5454

@@ -67,7 +67,7 @@ describe("useAddConnectedWallet", () => {
6767
},
6868
);
6969
const { result } = renderHook(() => useConnect(), { wrapper });
70-
expect(statusResult.current).toEqual("disconnected");
70+
expect(statusResult.current).toEqual("unknown");
7171
await result.current.connect(async () => wallet);
7272
expect(statusResult.current).toEqual("connected");
7373

@@ -85,7 +85,7 @@ describe("useAddConnectedWallet", () => {
8585
wrapper,
8686
},
8787
);
88-
expect(statusResult.current).toEqual("disconnected");
88+
expect(statusResult.current).toEqual("unknown");
8989
const { result } = renderHook(() => useConnect(), { wrapper });
9090
await result.current.connect(async () => {
9191
throw new Error("test");

packages/thirdweb/src/wallets/manager/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ import type { SmartWalletOptions } from "../smart/types.js";
1515
import type { WalletId } from "../wallet-types.js";
1616

1717
type WalletIdToConnectedWalletMap = Map<string, Wallet>;
18-
export type ConnectionStatus = "connected" | "disconnected" | "connecting";
18+
export type ConnectionStatus =
19+
| "connected"
20+
| "disconnected"
21+
| "connecting"
22+
| "unknown";
1923

2024
const CONNECTED_WALLET_IDS = "thirdweb:connected-wallet-ids";
2125
const LAST_ACTIVE_EOA_ID = "thirdweb:active-wallet-id";
@@ -47,7 +51,7 @@ export function createConnectionManager(storage: AsyncStorage) {
4751
const activeAccountStore = createStore<Account | undefined>(undefined);
4852
const activeWalletChainStore = createStore<Chain | undefined>(undefined);
4953
const activeWalletConnectionStatusStore =
50-
createStore<ConnectionStatus>("disconnected");
54+
createStore<ConnectionStatus>("unknown");
5155

5256
const definedChainsStore = createStore<Map<number, Chain>>(new Map());
5357

packages/thirdweb/test/vitest.config.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ export default defineConfig({
3838
globalSetup: [join(__dirname, "./globalSetup.ts")],
3939
testTimeout: 90_000,
4040
retry: 3,
41-
maxConcurrency: 3,
41+
maxConcurrency: 1,
42+
maxWorkers: 4,
43+
minWorkers: 2,
4244
bail: 1,
4345
// clear any mocks between any tests
4446
clearMocks: true,

0 commit comments

Comments
 (0)