fix(cli): fix execution on windows and when prettier is not installed (#2587)

Author: jnsdls

.changeset/smart-eggs-hammer.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+[CLI] - fix execution on windows and when prettier is not installed

packages/thirdweb/src/cli/bin.ts

@@ -23,21 +23,39 @@ async function main() {
     }
 
     default: {
+      const isWindows = /^win/.test(process.platform);
       let bunAvailable = false;
-      try {
-        const res = execSync("bun --version", {
-          stdio: "ignore",
-          encoding: "utf-8",
-        });
-        if (typeof res === "string" && res.indexOf(".") > -1) {
-          bunAvailable = true;
+      // bun has no windows support yet anyways
+      if (!isWindows) {
+        try {
+          const res = execSync("bun --version", {
+            stdio: "ignore",
+            encoding: "utf-8",
+          });
+          if (typeof res === "string" && res.indexOf(".") > -1) {
+            bunAvailable = true;
+          }
+        } catch {
+          bunAvailable = false;
         }
-      } catch {
-        bunAvailable = false;
       }
-      const runner = bunAvailable ? "bunx" : "npx";
+      let runner = "npx";
+
+      switch (true) {
+        case bunAvailable:
+          runner = "bun";
+          break;
+        case isWindows:
+          runner = "npx.cmd";
+          break;
+      }
+
+      const args = command
+        ? ["--yes", "@thirdweb-dev/cli@latest", command, ...rest]
+        : ["--yes", "@thirdweb-dev/cli@latest", ...rest];
+
       // eslint-disable-next-line better-tree-shaking/no-top-level-side-effects
-      spawn(runner, ["--yes", "@thirdweb-dev/cli@latest", command, ...rest], {
+      spawn(runner, args, {
         stdio: "inherit",
       });
     }

packages/thirdweb/src/cli/commands/generate/generate.ts

@@ -12,12 +12,13 @@ import {
   type AbiFunction,
   formatAbiItem,
 } from "abitype";
-import { format } from "prettier";
+
 import { prepareMethod } from "../../../utils/abi/prepare-method.js";
 import { mkdir, writeFile } from "node:fs/promises";
 import { packageDirectory } from "./utils.js";
 import { join } from "node:path";
 import { existsSync } from "node:fs";
+import type { Options } from "prettier";
 
 const client = createThirdwebClient({ clientId: "test" });
 
@@ -150,7 +151,7 @@ async function generateFromAbi(abi: Abi | string[]) {
     );
   }
 
-  const prettified = await format(body, {
+  const prettified = await prettifyCode(body, {
     parser: "babel-ts",
   });
   return prettified;
@@ -330,3 +331,18 @@ function lowercaseFirstLetter(str: string) {
 function eventNameToPreparedEventName(name: string) {
   return `${lowercaseFirstLetter(name)}Event`;
 }
+
+const printedPrettierWarning = false;
+
+async function prettifyCode(code: string, options: Options) {
+  try {
+    const { format } = await import("prettier/standalone.js");
+    return await format(code, options);
+  } catch (e) {
+    if (!printedPrettierWarning) {
+      console.info("Prettier not found, skipping code formatting.");
+    }
+  }
+
+  return code;
+}