Fix(Marketplace): Increase gas on writes (#2951)

Author: gregfromstl

.changeset/fair-snakes-sort.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Increase gas on MarketplaceV3 writes

packages/thirdweb/src/extensions/marketplace/direct-listings/write/buyFromListing.ts

@@ -59,6 +59,7 @@ export function buyFromListing(
           value: isNativeTokenAddress(listing.currencyContractAddress)
             ? listing.pricePerToken * options.quantity
             : 0n,
+          extraGas: 50_000n, // add extra gas to account for router call
         },
       };
     },

packages/thirdweb/src/extensions/marketplace/direct-listings/write/createListing.ts

@@ -167,6 +167,9 @@ export function createListing(
           endTimestamp,
           reserved: options.isReservedListing ?? false,
         },
+        overrides: {
+          extraGas: 50_000n, // add extra gas to account for router call
+        },
       } as const;
     },
   });

packages/thirdweb/src/extensions/marketplace/direct-listings/write/updateListing.ts

@@ -190,6 +190,9 @@ export function updateListing(
           endTimestamp,
           reserved: mergedOptions.isReservedListing ?? false,
         },
+        overrides: {
+          extraGas: 50_000n, // add extra gas to account for router call
+        },
       } as const;
     },
   });

packages/thirdweb/src/extensions/marketplace/english-auctions/write/bidInAuction.ts

@@ -94,6 +94,7 @@ export function bidInAuction(
           value: isNativeTokenAddress(auction.currencyContractAddress)
             ? resolvedBidAmountWei
             : undefined,
+          extraGas: 50_000n, // add extra gas to account for router call
         },
       };
     },

packages/thirdweb/src/extensions/marketplace/english-auctions/write/buyoutAuction.ts

@@ -40,6 +40,7 @@ export function buyoutAuction(
           value: isNativeTokenAddress(auction.currencyContractAddress)
             ? auction.buyoutBidAmount
             : undefined,
+          extraGas: 50_000n, // add extra gas to account for router call
         },
       };
     },

packages/thirdweb/src/extensions/marketplace/english-auctions/write/cancelAuction.ts

@@ -38,6 +38,9 @@ export function cancelAuction(
       }
       return {
         auctionId: options.auctionId,
+        overrides: {
+          extraGas: 50_000n, // add extra gas to account for router call
+        },
       };
     },
   });

packages/thirdweb/src/extensions/marketplace/english-auctions/write/createAuction.ts

@@ -229,6 +229,9 @@ export function createAuction(
           bidBufferBps: BigInt(options.bidBufferBps ?? 500),
           timeBufferInSeconds: BigInt(options.timeBufferInSeconds ?? 900),
         },
+        overrides: {
+          extraGas: 50_000n, // add extra gas to account for router call
+        },
       } as const;
     },
   });

packages/thirdweb/src/extensions/marketplace/english-auctions/write/executeSale.ts

@@ -44,6 +44,9 @@ export function executeSale(
           encodeCollectAuctionTokens({ auctionId: options.auctionId }),
           encodeCollectAuctionPayout({ auctionId: options.auctionId }),
         ],
+        overrides: {
+          extraGas: 50_000n, // add extra gas to account for router call
+        },
       };
     },
   });

packages/thirdweb/src/react/web/ui/TransactionButton/index.tsx

@@ -7,6 +7,7 @@ import {
 } from "../../../../transaction/actions/wait-for-tx-receipt.js";
 import type { PreparedTransaction } from "../../../../transaction/prepare-transaction.js";
 import type { TransactionReceipt } from "../../../../transaction/types.js";
+import { stringify } from "../../../../utils/json.js";
 import {
   useActiveAccount,
   useActiveWallet,
@@ -167,7 +168,7 @@ export function TransactionButton(props: TransactionButtonProps) {
             const receipt = await doWaitForReceipt(result);
             if (receipt.status === "reverted")
               throw new Error(
-                `Execution reverted: ${JSON.stringify(receipt, null, 2)}`,
+                `Execution reverted: ${stringify(receipt, null, 2)}`,
               );
             onTransactionConfirmed(receipt);
           }