fix(cli): fix spawn issue on windows (#2799)

Author: jnsdls

.changeset/stale-tips-fetch.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+fix `npx thirdweb` on windows when `thirdweb` is installed locally

packages/thirdweb/package.json

@@ -202,5 +202,9 @@
   },
   "engines": {
     "node": ">=18"
+  },
+  "devDependencies": {
+    "@types/cross-spawn": "^6.0.6",
+    "cross-spawn": "7.0.3"
   }
 }

packages/thirdweb/src/cli/bin.ts

@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import { spawn } from "cross-spawn";
 import {
   generate,
   isValidChainIdAndContractAddress,
@@ -24,25 +25,24 @@ async function main() {
 
     default: {
       const isWindows = /^win/.test(process.platform);
-      let bunAvailable = false;
-      // bun has no windows support yet anyways
-      if (!isWindows) {
+
+      const isBunAvailable = (() => {
         try {
           const res = execSync("bun --version", {
             stdio: "ignore",
             encoding: "utf-8",
           });
           if (typeof res === "string" && res.indexOf(".") > -1) {
-            bunAvailable = true;
+            return true;
           }
-        } catch {
-          bunAvailable = false;
-        }
-      }
+        } catch {}
+        return false;
+      })();
+
       let runner = "npx";
 
       switch (true) {
-        case bunAvailable:
+        case isBunAvailable:
           runner = "bun";
           break;
         case isWindows: