Skip to content

Commit 2914a50

Browse files
committed
Chore: deprecate iframe (#4991)
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on deprecating two authentication strategies in the `types.ts` file related to in-app wallets. The strategies for `iframe_email_verification` and `iframe` are marked as deprecated, which indicates they should not be used in future implementations. ### Detailed summary - Added `@deprecated` comment to the `iframe_email_verification` strategy. - Added `@deprecated` comment to the `iframe` strategy. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
1 parent 1b559bf commit 2914a50

File tree

1 file changed

+13
-2
lines changed
  • packages/thirdweb/src/wallets/in-app/core/authentication

1 file changed

+13
-2
lines changed

packages/thirdweb/src/wallets/in-app/core/authentication/types.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,19 @@ export type SingleStepAuthArgsType =
3636
| SocialAuthArgsType
3737
| { strategy: "jwt"; jwt: string; encryptionKey: string }
3838
| { strategy: "auth_endpoint"; payload: string; encryptionKey: string }
39-
| { strategy: "iframe_email_verification"; email: string }
40-
| { strategy: "iframe" }
39+
| {
40+
/**
41+
* @deprecated
42+
*/
43+
strategy: "iframe_email_verification";
44+
email: string;
45+
}
46+
| {
47+
/**
48+
* @deprecated
49+
*/
50+
strategy: "iframe";
51+
}
4152
| {
4253
strategy: "passkey";
4354
/**

0 commit comments

Comments
 (0)