ERC721 signature mint (#2554)

Author: joaquim-verges

packages/thirdweb/scripts/generate/abis/erc721/ISignatureDropERC721.json

@@ -1,5 +1,5 @@
 [
-  "event TokensMintedWithSignature(address indexed signer, address indexed mintedTo, uint256 indexed tokenIdMinted, (address to, address royaltyRecipient, uint256 royaltyBps, address primarySaleRecipient, string uri, uint256 quantity, uint256 pricePerToken, address currency, uint128 validityStartTimestamp, uint128 validityEndTimestamp, bytes32 uid) mintRequest)",
-  "function mintWithSignature((address to, address royaltyRecipient, uint256 royaltyBps, address primarySaleRecipient, string uri, uint256 quantity, uint256 pricePerToken, address currency, uint128 validityStartTimestamp, uint128 validityEndTimestamp, bytes32 uid) req, bytes signature) payable returns (address signer)",
-  "function verify((address to, address royaltyRecipient, uint256 royaltyBps, address primarySaleRecipient, string uri, uint256 quantity, uint256 pricePerToken, address currency, uint128 validityStartTimestamp, uint128 validityEndTimestamp, bytes32 uid) req, bytes signature) view returns (bool success, address signer)"
+  "event TokensMintedWithSignature(address indexed signer, address indexed mintedTo, uint256 indexed tokenIdMinted, (address to,address royaltyRecipient,uint256 royaltyBps,address primarySaleRecipient,string uri,uint256 price,address currency,uint128 validityStartTimestamp,uint128 validityEndTimestamp,bytes32 uid) mintpayload)",
+  "function mintWithSignature((address to,address royaltyRecipient,uint256 royaltyBps,address primarySaleRecipient,string uri,uint256 price,address currency,uint128 validityStartTimestamp,uint128 validityEndTimestamp,bytes32 uid) payload, bytes signature) payable returns (address signer)",
+  "function verify((address to,address royaltyRecipient,uint256 royaltyBps,address primarySaleRecipient,string uri,uint256 price,address currency,uint128 validityStartTimestamp,uint128 validityEndTimestamp,bytes32 uid) payload, bytes signature) view returns (bool success, address signer)"
 ]

packages/thirdweb/scripts/generate/abis/erc721/ISignatureMintERC721.json

@@ -83,6 +83,11 @@ export async function resolveAbiFromContractApi(
     `${contractApiBaseUrl}/${contract.chain.id}/${contract.address}`,
   );
   const json = await response.json();
+  if (!json || json.error) {
+    throw new Error(
+      `Failed to resolve ABI from contract API. ${json.error || ""}`,
+    );
+  }
   return json;
 }
 

packages/thirdweb/src/contract/actions/resolve-abi.ts

@@ -97,3 +97,12 @@ export {
   claimTo,
   type ClaimToParams,
 } from "../../extensions/erc721/drops/write/claimTo.js";
+
+/**
+ * SIGNATURE extension for ERC721
+ */
+export {
+  mintWithSignature,
+  type GenerateMintSignatureOptions,
+  generateMintSignature,
+} from "../../extensions/erc721/write/sigMint.js";

packages/thirdweb/src/exports/extensions/erc721.ts

@@ -1,6 +1,5 @@
 import type { BaseTransactionOptions } from "../../../transaction/types.js";
 import { nextTokenIdToClaim } from "../__generated__/IDrop/read/nextTokenIdToClaim.js";
-import { totalMinted } from "../__generated__/ISignatureDropERC721/read/totalMinted.js";
 
 /**
  * Retrieves the total claimed supply of ERC721 tokens.
@@ -21,14 +20,5 @@ import { totalMinted } from "../__generated__/ISignatureDropERC721/read/totalMin
 export async function getTotalClaimedSupply(
   options: BaseTransactionOptions,
 ): Promise<bigint> {
-  const results = await Promise.allSettled([
-    totalMinted(options),
-    nextTokenIdToClaim(options),
-  ]);
-  for (const result of results) {
-    if (result.status === "fulfilled") {
-      return result.value;
-    }
-  }
-  throw new Error("Failed to get total claimed supply");
+  return nextTokenIdToClaim(options);
 }

packages/thirdweb/src/extensions/erc721/__generated__/ISignatureDropERC721/read/totalMinted.ts

@@ -1,22 +1,6 @@
-import type { FileOrBufferOrString } from "../../../storage/upload/types.js";
 import type { BaseTransactionOptions } from "../../../transaction/types.js";
-import type { Prettify } from "../../../utils/type-utils.js";
+import type { NFTInput } from "../../../utils/nft/parseNft.js";
 import { mintTo as generatedMintTo } from "../__generated__/IMintableERC721/write/mintTo.js";
-/**
- * Represents the input data for creating an NFT (Non-Fungible Token).
- */
-type NFTInput = Prettify<
-  {
-    name?: string;
-    description?: string;
-    image?: FileOrBufferOrString;
-    animation_url?: FileOrBufferOrString;
-    external_url?: FileOrBufferOrString;
-    background_color?: string;
-    // TODO check if we truly need both of these?
-    properties?: Record<string, unknown> | Array<Record<string, unknown>>;
-  } & Record<string, unknown>
->;
 
 export type MintToParams = {
   to: string;