Skip to content

Commit deb7908

Browse files
authored
refactor: Update getAwsKmsAccount and getGcpKmsAccount to use hashMessage from thirdweb/utils (#722)
1 parent 296f142 commit deb7908

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

src/server/utils/wallets/getAwsKmsAccount.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
type Address,
99
} from "thirdweb";
1010
import { serializeTransaction } from "thirdweb/transaction";
11-
import { toBytes } from "thirdweb/utils";
11+
import { hashMessage } from "thirdweb/utils";
1212
import type { Account } from "thirdweb/wallets";
1313
import type {
1414
SignableMessage,
@@ -78,16 +78,7 @@ export async function getAwsKmsAccount(
7878
}: {
7979
message: SignableMessage;
8080
}): Promise<Hex> {
81-
let messageHash: Hex;
82-
if (typeof message === "string") {
83-
const prefixedMessage = `\x19Ethereum Signed Message:\n${message.length}${message}`;
84-
messageHash = keccak256(toBytes(prefixedMessage));
85-
} else if ("raw" in message) {
86-
messageHash = keccak256(message.raw);
87-
} else {
88-
throw new Error("Invalid message format");
89-
}
90-
81+
const messageHash = hashMessage(message);
9182
const signature = await signer.sign(
9283
Buffer.from(messageHash.slice(2), "hex"),
9384
);

src/server/utils/wallets/getGcpKmsAccount.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
keccak256,
99
} from "thirdweb";
1010
import { serializeTransaction } from "thirdweb/transaction";
11-
import { toBytes } from "thirdweb/utils";
11+
import { hashMessage } from "thirdweb/utils";
1212
import type { Account } from "thirdweb/wallets";
1313
import type {
1414
SignableMessage,
@@ -98,16 +98,7 @@ export async function getGcpKmsAccount(
9898
}: {
9999
message: SignableMessage;
100100
}): Promise<Hex> {
101-
let messageHash: Hex;
102-
if (typeof message === "string") {
103-
const prefixedMessage = `\x19Ethereum Signed Message:\n${message.length}${message}`;
104-
messageHash = keccak256(toBytes(prefixedMessage));
105-
} else if ("raw" in message) {
106-
messageHash = keccak256(message.raw);
107-
} else {
108-
throw new Error("Invalid message format");
109-
}
110-
101+
const messageHash = hashMessage(message);
111102
const signature = await signer.sign(Bytes.fromString(messageHash));
112103
return signature.bytes.toString() as Hex;
113104
}

0 commit comments

Comments
 (0)