Skip to content

Commit 8992694

Browse files
authored
fix: unused fields causing build to fail (#700)
* fix: unused fields causing build to fail * check build action * small change to readme
1 parent 7cd575b commit 8992694

File tree

4 files changed

+26
-3
lines changed

4 files changed

+26
-3
lines changed

.github/workflows/check-build.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: Check Build
2+
3+
on: pull_request
4+
5+
jobs:
6+
build:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- name: Checkout code
10+
uses: actions/checkout@v3
11+
with:
12+
ref: ${{ github.ref }}
13+
14+
- name: Set up Node.js
15+
uses: actions/setup-node@v3
16+
with:
17+
node-version: "18"
18+
cache: "yarn"
19+
20+
- name: Install dependencies
21+
run: yarn install
22+
23+
- name: Run build
24+
run: yarn build

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Engine is an open-source, backend HTTP server that provides a production-ready i
3333
- 700+ transactions sent onchain per second (can fill up an EVM block!)
3434
- Managed backend wallets (local, KMS)
3535
- Contract calls and deployments ([all EVM blockchains](https://thirdweb.com/chainlist) + private subnets)
36-
- Gas optimizations with retries
36+
- Gas-optimized retries, gas ceilings, and timeouts
3737
- Smart account support with session tokens
3838
- Gasless transactions with relayers
3939
- Wallet and contract webhooks

src/server/schemas/transaction/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ export const toTransactionSchema = (
264264
if (transaction.status === "sent") {
265265
return transaction.gasPrice?.toString() ?? null;
266266
}
267-
return transaction.overrides?.gasPrice?.toString() ?? null;
267+
return null;
268268
};
269269

270270
const resolveMaxFeePerGas = (): string | null => {

src/worker/tasks/migratePostgresTransactionsWorker.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,6 @@ const toQueuedTransaction = (row: Transactions): QueuedTransaction => {
209209

210210
overrides: {
211211
gas: maybeBigInt(row.gasLimit ?? undefined),
212-
gasPrice: maybeBigInt(row.gasPrice ?? undefined),
213212
maxFeePerGas: maybeBigInt(row.maxFeePerGas ?? undefined),
214213
maxPriorityFeePerGas: maybeBigInt(row.maxPriorityFeePerGas ?? undefined),
215214
},

0 commit comments

Comments
 (0)