fix: remove legacy package; update withdraw endpoint (#465)

* fix: use thirdweb sdk for gas estimation

* dummy value when estimating cost

* remove unneeded try/catch

Author: arcoraven

package.json

@@ -30,7 +30,6 @@
   },
   "dependencies": {
     "@aws-sdk/client-kms": "^3.398.0",
-    "@eth-optimism/sdk": "^3.1.6",
     "@fastify/cookie": "^8.3.0",
     "@fastify/cors": "^8.2.1",
     "@fastify/express": "^2.3.0",
@@ -68,7 +67,7 @@
     "pino": "^8.15.1",
     "pino-pretty": "^10.0.0",
     "prisma": "^5.2.0",
-    "thirdweb": "^1.0.0-beta-0e947333cefd127c2ccda059c775d2975021be33-20240229054327",
+    "thirdweb": "^5.0.0-beta-ca68bc77e74f594360b4da1e9e77793b66cfb12a-20240323045412",
     "uuidv4": "^6.2.13",
     "viem": "^1.14.0",
     "zod": "^3.21.4"

src/utils/env.ts

@@ -3,10 +3,7 @@ import * as dotenv from "dotenv";
 import type { ZodError } from "zod";
 import { z } from "zod";
 
-dotenv.config({
-  debug: true,
-  override: false,
-});
+dotenv.config();
 
 export const JsonSchema = z.string().refine(
   (value) => {

src/utils/sdk.ts

@@ -1,6 +1,11 @@
 import { sha256HexSync } from "@thirdweb-dev/crypto";
+import { createThirdwebClient } from "thirdweb";
 import { env } from "./env";
 
 export const thirdwebClientId = sha256HexSync(
   env.THIRDWEB_API_SECRET_KEY,
 ).slice(0, 32);
+
+export const thirdwebClient = createThirdwebClient({
+  clientId: thirdwebClientId,
+});

src/worker/tasks/processTx.ts

@@ -34,7 +34,7 @@ import {
   sendWebhooks,
 } from "../../utils/webhook";
 import { randomNonce } from "../utils/nonce";
-import { getWithdrawalValue } from "../utils/withdraw";
+import { getWithdrawValue } from "../utils/withdraw";
 
 type RpcResponseData = {
   tx: Transactions;
@@ -161,13 +161,12 @@ export const processTx = async () => {
             try {
               let value = BigNumber.from(tx.value ?? 0);
               if (tx.extension === "withdraw") {
-                value = await getWithdrawalValue({
-                  provider,
+                const withdrawValue = await getWithdrawValue({
                   chainId,
                   fromAddress: tx.fromAddress!,
                   toAddress: tx.toAddress!,
-                  gasOverrides,
                 });
+                value = BigNumber.from(withdrawValue.toString());
               }
 
               const txRequest = await signer.populateTransaction({

src/worker/utils/withdraw.ts

@@ -1,41 +1,46 @@
-import { asL2Provider } from "@eth-optimism/sdk";
-import { Base, Optimism, Zora } from "@thirdweb-dev/chains";
-import { getDefaultGasOverrides, toUnits } from "@thirdweb-dev/sdk";
-import { BigNumber, ethers } from "ethers";
+import { defineChain, prepareTransaction } from "thirdweb";
+import { ethers5Adapter } from "thirdweb/adapters/ethers5";
+import { estimateGasCost } from "thirdweb/transaction";
+import { getWalletBalance } from "thirdweb/wallets";
+import { getWallet } from "../../utils/cache/getWallet";
+import { thirdwebClient } from "../../utils/sdk";
 
-interface GetWithdrawalValueParams {
-  provider: ethers.providers.Provider;
+interface GetWithdrawValueParams {
   chainId: number;
   fromAddress: string;
   toAddress: string;
-  gasOverrides: Awaited<ReturnType<typeof getDefaultGasOverrides>>;
 }
 
-export const getWithdrawalValue = async ({
-  provider,
+export const getWithdrawValue = async ({
   chainId,
   fromAddress,
   toAddress,
-  gasOverrides,
-}: GetWithdrawalValueParams): Promise<BigNumber> => {
-  const balance = await provider.getBalance(fromAddress);
+}: GetWithdrawValueParams): Promise<bigint> => {
+  const chain = defineChain(chainId);
 
-  let transferCost = BigNumber.from(
-    gasOverrides.maxFeePerGas || gasOverrides.gasPrice || toUnits(1, 9),
-  ).mul(21000);
+  // Get wallet balance.
+  const wallet = await getWallet({ chainId, walletAddress: fromAddress });
+  const signer = await wallet.getSigner();
+  const account = await ethers5Adapter.signer.fromEthers(signer);
+  const { value: balanceWei } = await getWalletBalance({
+    account,
+    client: thirdwebClient,
+    chain,
+  });
 
-  if (
-    chainId === Base.chainId ||
-    chainId === Optimism.chainId ||
-    chainId === Zora.chainId
-  ) {
-    const l2Provider = asL2Provider(provider);
-    transferCost = await l2Provider.estimateTotalGasCost({
-      to: toAddress,
-      value: 1,
-    });
-  }
+  // Estimate gas for a transfer.
+  const transferTx = prepareTransaction({
+    value: BigInt(1),
+    to: toAddress,
+    chain,
+    client: thirdwebClient,
+  });
+  const { wei: transferCostWei } = await estimateGasCost({
+    transaction: transferTx,
+  });
 
-  transferCost = transferCost.mul(120).div(100); // +20% in all cases for safety
-  return BigNumber.from(balance).sub(transferCost);
+  // Add a 20% buffer for gas variance.
+  const buffer = BigInt(Math.round(Number(transferCostWei) * 0.2));
+
+  return balanceWei - transferCostWei - buffer;
 };