fix: correct conversion of legacy typo-containing strings in getGcpKmsAccount (#721)

yukia3e · web-flow · commit 420350fa9c59 · 2024-10-11T19:22:09.000+05:30
diff --git a/src/server/utils/wallets/getGcpKmsAccount.ts b/src/server/utils/wallets/getGcpKmsAccount.ts
@@ -52,12 +52,12 @@ export async function getGcpKmsAccount(
     }
   }
 
-  // we had a bug previously where we previously called it "cryptoKeyVersion" instead of "cryptoKeyVersions"
+  // we had a bug previously where we previously called it "cryptoKeysVersion" instead of "cryptoKeyVersions"
   // if we detect that, we'll fix it here
   // TODO: remove this as a breaking change
   const name = unprocessedName.includes("cryptoKeyVersions")
     ? unprocessedName
-    : unprocessedName.replace("cryptoKeyVersion", "cryptoKeyVersions");
+    : unprocessedName.replace("cryptoKeysVersion", "cryptoKeyVersions");
 
   const signer = new CloudKmsSigner(name, clientOptions);
 

Original file line number	Diff line number	Diff line change
`@@ -52,12 +52,12 @@ export async function getGcpKmsAccount(`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`- // we had a bug previously where we previously called it "cryptoKeyVersion" instead of "cryptoKeyVersions"`
	`55`	`+ // we had a bug previously where we previously called it "cryptoKeysVersion" instead of "cryptoKeyVersions"`
`56`	`56`	`// if we detect that, we'll fix it here`
`57`	`57`	`// TODO: remove this as a breaking change`
`58`	`58`	`const name = unprocessedName.includes("cryptoKeyVersions")`
`59`	`59`	`? unprocessedName`
`60`		`- : unprocessedName.replace("cryptoKeyVersion", "cryptoKeyVersions");`
	`60`	`+ : unprocessedName.replace("cryptoKeysVersion", "cryptoKeyVersions");`
`61`	`61`
`62`	`62`	`const signer = new CloudKmsSigner(name, clientOptions);`
`63`	`63`