Skip to content

Commit 3337fd6

Browse files
authored
fixes build errors caused due to multiple / characters in the image tag (#682)
1 parent 0ed46cc commit 3337fd6

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
cache-to: |
3939
type=gha,scope=${{ matrix.platform }},mode=max
4040
type=registry,ref=thirdweb/engine:buildcache-${{ matrix.platform }},mode=max
41-
tags: thirdweb/engine:nightly-${{ matrix.platform }}
41+
tags: thirdweb/engine:nightly-${{ matrix.platform == 'linux/amd64' && 'amd64' || 'arm64' }}
4242
build-args: |
4343
ENGINE_VERSION=nightly
4444
@@ -55,6 +55,6 @@ jobs:
5555
- name: Create and Push Multi-arch Manifest (nightly)
5656
run: |
5757
docker manifest create thirdweb/engine:nightly \
58-
thirdweb/engine:nightly-linux/amd64 \
59-
thirdweb/engine:nightly-linux/arm64
60-
docker manifest push thirdweb/engine:nightly
58+
thirdweb/engine:nightly-amd64 \
59+
thirdweb/engine:nightly-arm64
60+
docker manifest push thirdweb/engine:nightly

.github/workflows/tagBasedImageBuild.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ jobs:
4141
cache-to: |
4242
type=gha,scope=${{ matrix.platform }},mode=max
4343
type=registry,ref=thirdweb/engine:buildcache-${{ matrix.platform }},mode=max
44-
tags: thirdweb/engine:${{ github.event.release.tag_name }}-${{ matrix.platform }}
44+
tags: |
45+
thirdweb/engine:${{ github.event.release.tag_name }}-${{ matrix.platform == 'linux/amd64' && 'amd64' || 'arm64' }}
46+
${{ env.LATEST_TAG != '' && format('thirdweb/engine:latest-{0}', matrix.platform == 'linux/amd64' && 'amd64' || 'arm64') || '' }}
4547
build-args: |
4648
ENGINE_VERSION=${{ github.event.release.tag_name }}
4749
@@ -57,17 +59,17 @@ jobs:
5759
username: ${{ secrets.DOCKER_USERNAME }}
5860
password: ${{ secrets.DOCKER_PASSWORD }}
5961

60-
- name: Create and Push Multi-arch Manifest
62+
- name: Create and Push Multi-arch Manifest (release tag)
6163
run: |
6264
docker manifest create thirdweb/engine:${{ github.event.release.tag_name }} \
63-
thirdweb/engine:${{ github.event.release.tag_name }}-linux/amd64 \
64-
thirdweb/engine:${{ github.event.release.tag_name }}-linux/arm64
65+
thirdweb/engine:${{ github.event.release.tag_name }}-amd64 \
66+
thirdweb/engine:${{ github.event.release.tag_name }}-arm64
6567
docker manifest push thirdweb/engine:${{ github.event.release.tag_name }}
6668
6769
- name: Create and Push Latest Tag (if applicable)
6870
if: ${{ env.LATEST_TAG != '' }}
6971
run: |
7072
docker manifest create thirdweb/engine:latest \
71-
thirdweb/engine:${{ github.event.release.tag_name }}-linux/amd64 \
72-
thirdweb/engine:${{ github.event.release.tag_name }}-linux/arm64
73-
docker manifest push thirdweb/engine:latest
73+
thirdweb/engine:latest-amd64 \
74+
thirdweb/engine:latest-arm64
75+
docker manifest push thirdweb/engine:latest

0 commit comments

Comments
 (0)