lua script default to 0

Author: arcoraven

src/db/wallets/walletNonce.ts

@@ -194,7 +194,7 @@ export const deleteAllNonces = async () => {
  * @param chainId
  * @param walletAddress
  */
-export const rebaseNonce = async (chainId: number, walletAddress: Address) => {
+export const resyncNonce = async (chainId: number, walletAddress: Address) => {
   const rpcRequest = getRpcClient({
     client: thirdwebClient,
     chain: await getChain(chainId),
@@ -205,10 +205,10 @@ export const rebaseNonce = async (chainId: number, walletAddress: Address) => {
     address: walletAddress,
   });
 
-  // Lua script to set nonce as max
+  // Lua script to update the DB nonce only if the onchain nonce is higher.
   const script = `
     local transactionCount = tonumber(ARGV[1])
-    local lastUsedNonce = tonumber(redis.call('get', KEYS[1]))
+    local lastUsedNonce = tonumber(redis.call('get', KEYS[1])) or 0
     local nextNonce = math.max(transactionCount-1, lastUsedNonce)
     redis.call('set', KEYS[1], nextNonce)
     return nextNonce

src/worker/tasks/sendTransactionWorker.ts

@@ -10,8 +10,8 @@ import { TransactionDB } from "../../db/transactions/db";
 import {
   acquireNonce,
   addSentNonce,
-  rebaseNonce,
   recycleNonce,
+  resyncNonce,
 } from "../../db/wallets/walletNonce";
 import { getAccount } from "../../utils/account";
 import { getBlockNumberish } from "../../utils/block";
@@ -174,12 +174,13 @@ const _sendTransaction = async (
     transactionHash = sendTransactionResult.transactionHash;
     job.log(`Sent transaction: ${transactionHash}`);
   } catch (error: unknown) {
-    // If NonceAlreadyUsedError, which can also manifest as a ReplacementGasFeeTooLowError,
-    // recycle the nonce and retry the transaction.
+    // If the nonce is already seen onchain (nonce too low) or in mempool (replacement underpriced),
+    // correct the DB nonce.
     if (isNonceAlreadyUsedError(error) || isReplacementGasFeeTooLow(error)) {
-      const resyncNonce = await rebaseNonce(chainId, from);
-      job.log(`Resynced nonce to ${resyncNonce}.`);
+      const result = await resyncNonce(chainId, from);
+      job.log(`Resynced nonce to ${result}.`);
     } else {
+      // Otherwise this nonce is not used yet. Recycle it to be used by a future transaction.
       job.log(`Recycling nonce: ${nonce}`);
       await recycleNonce(chainId, from, nonce);
     }