Fixes for simulation on error & other fixes (#471)

Author: farhanW3

src/db/transactions/getSentTxs.ts

@@ -21,7 +21,6 @@ export const getSentTxs = async ({ pgtx }: GetSentTxsParams = {}): Promise<
     AND "accountAddress" IS NULL
     AND "minedAt" IS NULL
     AND "errorMessage" IS NULL
-    AND "retryCount" < ${config.maxTxsToUpdate}
     ORDER BY "nonce" ASC
     LIMIT ${config.maxTxsToUpdate}
     FOR UPDATE SKIP LOCKED

src/db/transactions/updateTx.ts

@@ -96,6 +96,7 @@ export const updateTx = async ({ pgtx, queueId, data }: UpdateTxParams) => {
           gasLimit: data.res?.gasLimit?.toString(),
           maxFeePerGas: data.res?.maxFeePerGas?.toString(),
           maxPriorityFeePerGas: data.res?.maxPriorityFeePerGas?.toString(),
+          value: data.res?.value?.toString(),
         },
       });
       break;
@@ -119,13 +120,11 @@ export const updateTx = async ({ pgtx, queueId, data }: UpdateTxParams) => {
           minedAt: data.minedAt,
           blockNumber: data.blockNumber,
           onChainTxStatus: data.onChainTxStatus,
-          transactionHash: data.transactionHash,
           transactionType: data.transactionType,
           gasPrice: data.gasPrice,
           gasLimit: data.gasLimit,
           maxFeePerGas: data.maxFeePerGas,
           maxPriorityFeePerGas: data.maxPriorityFeePerGas,
-          nonce: data.nonce,
         },
       });
       break;

src/utils/errors.ts

@@ -28,29 +28,30 @@ export const parseTxError = async (
     return "Unexpected error.";
   }
 
-  const chain = await getChainByChainIdAsync(Number(tx.chainId));
+  // EOA transactions
+  if (tx.toAddress && tx.fromAddress && tx.data) {
+    const chain = await getChainByChainIdAsync(Number(tx.chainId));
 
-  if ((err as EthersError)?.code === ethers.errors.INSUFFICIENT_FUNDS) {
-    return `Insufficient ${chain.nativeCurrency?.symbol} on ${
-      chain.name
-    } in backend wallet ${tx.fromAddress!}.`;
-  }
+    if ((err as EthersError)?.code === ethers.errors.INSUFFICIENT_FUNDS) {
+      return `Insufficient ${chain.nativeCurrency?.symbol} on ${chain.name} in backend wallet ${tx.fromAddress}.`;
+    }
 
-  if ((err as EthersError)?.code === ethers.errors.UNPREDICTABLE_GAS_LIMIT) {
-    try {
-      const transaction = prepareTransaction({
-        to: tx.toAddress!,
-        value: BigInt(tx.value!),
-        data: tx.data! as `0x${string}`,
-        chain: {
-          id: Number(tx.chainId!),
-          rpc: chain.rpc[0],
-        },
-        client,
-      });
-      await simulateTransaction({ transaction, from: tx.fromAddress! });
-    } catch (simErr: any) {
-      return simErr?.message ?? simErr.toString();
+    if ((err as EthersError)?.code === ethers.errors.UNPREDICTABLE_GAS_LIMIT) {
+      try {
+        const transaction = prepareTransaction({
+          to: tx.toAddress,
+          value: BigInt(tx.value || "0"),
+          data: tx.data as `0x${string}`,
+          chain: {
+            id: Number(tx.chainId),
+            rpc: chain.rpc[0],
+          },
+          client,
+        });
+        await simulateTransaction({ transaction, from: tx.fromAddress });
+      } catch (simErr: any) {
+        return simErr?.message ?? simErr.toString();
+      }
     }
   }
 

src/worker/tasks/updateMinedTx.ts

@@ -28,8 +28,6 @@ export const updateMinedTx = async () => {
           return;
         }
 
-        const droppedTxs: (Transactions & { provider?: string })[] = [];
-
         const txsWithReceipts = (
           await Promise.all(
             txs.map(async (tx) => {