Skip to content

Commit 9813557

Browse files
committed
remove redundant platform param
1 parent b14960d commit 9813557

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

Thirdweb.Console/Program.cs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,11 @@
7474

7575
#region Ecosystem Wallet
7676

77-
// var inAppWallet = await InAppWallet.Create(client: client, authProvider: AuthProvider.Google);
78-
// if (!await inAppWallet.IsConnected())
77+
// var ecosystemWallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosystem.the-bonfire", authProvider: AuthProvider.Telegram);
78+
79+
// if (!await ecosystemWallet.IsConnected())
7980
// {
80-
// _ = await inAppWallet.LoginWithOauth(
81+
// _ = await ecosystemWallet.LoginWithOauth(
8182
// isMobile: false,
8283
// (url) =>
8384
// {
@@ -88,16 +89,6 @@
8889
// new InAppWalletBrowser()
8990
// );
9091
// }
91-
92-
// var ecosystemWallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosystem.the-bonfire", email: "firekeeper@thirdweb.com");
93-
94-
// if (!await ecosystemWallet.IsConnected())
95-
// {
96-
// _ = await ecosystemWallet.SendOTP();
97-
// Console.WriteLine("Enter OTP:");
98-
// var otp = Console.ReadLine();
99-
// _ = await ecosystemWallet.LoginWithOtp(otp);
100-
// }
10192
// var ecosystemWalletAddress = await ecosystemWallet.GetAddress();
10293
// Console.WriteLine($"Ecosystem Wallet address: {ecosystemWalletAddress}");
10394

Thirdweb/Thirdweb.Wallets/InAppWallet/EcosystemWallet/EcosystemWallet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public async Task<string> LoginWithOtp(string otp)
465465
var platform = this._httpClient?.Headers?["x-sdk-name"] == "UnitySDK_WebGL" ? "web" : "dotnet";
466466
var redirectUrl = isMobile ? mobileRedirectScheme : "http://localhost:8789/";
467467
var loginUrl = await this._embeddedWallet.FetchHeadlessOauthLoginLinkAsync(this._authProvider, platform).ConfigureAwait(false);
468-
loginUrl = platform == "web" ? loginUrl : $"{loginUrl}?platform={platform}&redirectUrl={redirectUrl}&developerClientId={this.Client.ClientId}&authOption={this._authProvider}";
468+
loginUrl = platform == "web" ? loginUrl : $"{loginUrl}&redirectUrl={redirectUrl}&developerClientId={this.Client.ClientId}&authOption={this._authProvider}";
469469
loginUrl = $"{loginUrl}&ecosystemId={this._ecosystemId}";
470470
if (!string.IsNullOrEmpty(this._ecosystemPartnerId))
471471
{

Thirdweb/Thirdweb.Wallets/InAppWallet/InAppWallet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ public virtual async Task<string> LoginWithOauth(
331331
var platform = this.Client.HttpClient?.Headers?["x-sdk-name"] == "UnitySDK_WebGL" ? "web" : "dotnet";
332332
var redirectUrl = isMobile ? mobileRedirectScheme : "http://localhost:8789/";
333333
var loginUrl = await this.EmbeddedWallet.FetchHeadlessOauthLoginLinkAsync(this.AuthProvider, platform);
334-
loginUrl = platform == "web" ? loginUrl : $"{loginUrl}?platform={platform}&redirectUrl={redirectUrl}&developerClientId={this.Client.ClientId}&authOption={this.AuthProvider}";
334+
loginUrl = platform == "web" ? loginUrl : $"{loginUrl}&redirectUrl={redirectUrl}&developerClientId={this.Client.ClientId}&authOption={this.AuthProvider}";
335335

336336
browser ??= new InAppWalletBrowser();
337337
var browserResult = await browser.Login(this.Client, loginUrl, redirectUrl, browserOpenAction, cancellationToken);

0 commit comments

Comments
 (0)