Fix clippy warnings

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>

Author: didier-wenzek

crates/common/tedge_config_macros/src/multi.rs

@@ -416,7 +416,7 @@ mod tests {
         });
         let dto: TEdgeConfigDto = serde_json::from_value(val.clone()).unwrap();
 
-        assert_eq!(serde_json::to_value(&dto).unwrap(), val);
+        assert_eq!(serde_json::to_value(dto).unwrap(), val);
     }
 
     #[test]
@@ -431,7 +431,7 @@ mod tests {
         });
         let dto: TEdgeConfigDto = serde_json::from_value(val.clone()).unwrap();
 
-        assert_eq!(serde_json::to_value(&dto).unwrap(), val);
+        assert_eq!(serde_json::to_value(dto).unwrap(), val);
     }
 
     #[test]

crates/core/tedge/src/cli/connect/command.rs

@@ -718,7 +718,7 @@ fn check_device_status_azure(
     if tedge_config.mqtt.bridge.built_in {
         client.subscribe(&built_in_bridge_health, AtLeastOnce)?;
     }
-    client.subscribe(&azure_topic_device_twin_downstream, AtLeastOnce)?;
+    client.subscribe(azure_topic_device_twin_downstream, AtLeastOnce)?;
 
     let mut err = None;
     for event in connection.iter() {

crates/core/tedge/src/cli/connect/jwt_token.rs

@@ -33,7 +33,7 @@ pub(crate) fn get_connected_c8y_url(
     let mut acknowledged = false;
     let mut c8y_url: Option<String> = None;
 
-    client.subscribe(&c8y_topic_builtin_jwt_token_downstream, AtLeastOnce)?;
+    client.subscribe(c8y_topic_builtin_jwt_token_downstream, AtLeastOnce)?;
     let mut err = None;
 
     for event in connection.iter() {

crates/core/tedge_agent/src/operation_workflows/persist.rs

@@ -102,12 +102,13 @@ impl WorkflowRepository {
         for entry in dir_path.read_dir_utf8()?.flatten() {
             let file = entry.path();
             if file.extension() == Some("toml") {
-                match read_operation_workflow(file)
+                let result = read_operation_workflow(file)
                     .await
                     .and_then(|(workflow, version)| {
                         let file_source = source.set_inner(file.into());
                         self.load_operation_workflow(file_source, workflow, version)
-                    }) {
+                    });
+                match result {
                     Ok(cmd) => {
                         info!(
                             "Using operation workflow definition from {file:?} for '{cmd}' operation"

crates/core/tedge_api/src/workflow/state.rs

@@ -196,7 +196,7 @@ impl GenericCommandState {
             o.insert(key.into(), val.into());
         }
         if key == STATUS {
-            self.status = val.to_owned();
+            val.clone_into(&mut self.status)
         }
     }
 

plugins/c8y_remote_access_plugin/src/input.rs

@@ -130,7 +130,7 @@ impl RemoteAccessConnect {
             stdin.read_line(&mut command).unwrap();
 
             // If it's a smartrest message, it contains a ','
-            if !command.contains(",") {
+            if !command.contains(',') {
                 c8y_profile = Some(command.trim().parse().expect("Parsing profile name"));
                 command.clear();
                 stdin.read_line(&mut command).unwrap();