fixup! Improve error reporting on JS loading errors

didier-wenzek · didier-wenzek · commit f2ca7b55dc1c · 2025-07-22T21:51:48.000+02:00
diff --git a/crates/extensions/tedge_gen_mapper/src/js_runtime.rs b/crates/extensions/tedge_gen_mapper/src/js_runtime.rs
@@ -273,12 +273,12 @@ impl<'js> JsModules<'js> {
 }
 
 impl LoadError {
-    fn from_js<'js>(ctx: &Ctx<'js>, err: rquickjs::Error) -> Self {
+    fn from_js(ctx: &Ctx<'_>, err: rquickjs::Error) -> Self {
         if let Some(ex) = ctx.catch().as_exception() {
             let err = anyhow::anyhow!("{ex}");
             err.context("JS raised exception").into()
         } else {
-            let err = CaughtError::from_error(&ctx, err);
+            let err = CaughtError::from_error(ctx, err);
             let err = anyhow::anyhow!("{err}");
             err.context("JS runtime error").into()
         }

Original file line number	Diff line number	Diff line change
`@@ -273,12 +273,12 @@ impl<'js> JsModules<'js> {`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`impl LoadError {`
`276`		`- fn from_js<'js>(ctx: &Ctx<'js>, err: rquickjs::Error) -> Self {`
	`276`	`+ fn from_js(ctx: &Ctx<'_>, err: rquickjs::Error) -> Self {`
`277`	`277`	`if let Some(ex) = ctx.catch().as_exception() {`
`278`	`278`	`let err = anyhow::anyhow!("{ex}");`
`279`	`279`	`err.context("JS raised exception").into()`
`280`	`280`	`} else {`
`281`		`- let err = CaughtError::from_error(&ctx, err);`
	`281`	`+ let err = CaughtError::from_error(ctx, err);`
`282`	`282`	`let err = anyhow::anyhow!("{err}");`
`283`	`283`	`err.context("JS runtime error").into()`
`284`	`284`	`}`