Rename TEdgeConfig::new as try_new

as this might fail.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>

Author: didier-wenzek

crates/common/tedge_config/src/lib.rs

@@ -14,13 +14,13 @@ pub use tedge_config_macros::all_or_nothing;
 pub use tedge_config_macros::OptionalConfig;
 
 impl TEdgeConfig {
-    pub fn new(config_location: TEdgeConfigLocation) -> Result<Self, TEdgeConfigError> {
+    pub fn try_new(config_location: TEdgeConfigLocation) -> Result<Self, TEdgeConfigError> {
         config_location.load()
     }
 
     pub fn load(config_dir: &Path) -> Result<TEdgeConfig, TEdgeConfigError> {
         let config_location = TEdgeConfigLocation::from_custom_root(config_dir);
-        TEdgeConfig::new(config_location)
+        TEdgeConfig::try_new(config_location)
     }
 
     #[cfg(feature = "test")]

crates/core/plugin_sm/src/plugin_manager.rs

@@ -147,7 +147,7 @@ impl ExternalPlugins {
         self.plugin_map.clear();
 
         let config =
-            tedge_config::TEdgeConfig::new(self.config_location.clone()).map_err(|err| {
+            tedge_config::TEdgeConfig::try_new(self.config_location.clone()).map_err(|err| {
                 io::Error::new(
                     ErrorKind::Other,
                     format!("Failed to load tedge config: {}", err),

crates/core/plugin_sm/tests/plugin.rs

@@ -59,7 +59,7 @@ mod tests {
         let tmpfile = make_config(100)?;
         let config_location =
             TEdgeConfigLocation::from_custom_root(tmpfile.path().to_str().unwrap());
-        let config = tedge_config::TEdgeConfig::new(config_location)?;
+        let config = tedge_config::TEdgeConfig::try_new(config_location)?;
 
         let plugin = ExternalPluginCommand::new(
             "test",

crates/core/tedge/src/cli/certificate/upload.rs

@@ -51,7 +51,7 @@ impl UploadCertCmd {
             Err(_) => rpassword::read_password_from_tty(Some("Enter password: "))?,
         };
 
-        let config = TEdgeConfig::new(TEdgeConfigLocation::default())?;
+        let config = TEdgeConfig::try_new(TEdgeConfigLocation::default())?;
         let root_cert = &config.c8y.root_cert_path;
         let client_builder = reqwest::blocking::Client::builder();
         let res = match std::fs::metadata(root_cert) {

crates/core/tedge/src/command.rs

@@ -159,6 +159,6 @@ impl BuildContext {
     }
 
     pub fn load_config(&self) -> Result<tedge_config::TEdgeConfig, tedge_config::TEdgeConfigError> {
-        tedge_config::TEdgeConfig::new(self.config_location.clone())
+        tedge_config::TEdgeConfig::try_new(self.config_location.clone())
     }
 }

crates/core/tedge_agent/src/agent.rs

@@ -90,7 +90,7 @@ impl AgentConfig {
         tedge_config_location: &tedge_config::TEdgeConfigLocation,
         cliopts: AgentOpt,
     ) -> Result<Self, anyhow::Error> {
-        let tedge_config = tedge_config::TEdgeConfig::new(tedge_config_location.clone())?;
+        let tedge_config = tedge_config::TEdgeConfig::try_new(tedge_config_location.clone())?;
 
         let config_dir = tedge_config_location.tedge_config_root_path.clone();
         let tmp_dir = Arc::from(tedge_config.tmp.path.as_path());

crates/core/tedge_agent/src/restart_manager/config.rs

@@ -14,7 +14,7 @@ impl RestartManagerConfig {
         device_topic_id: &EntityTopicId,
         tedge_config_location: &tedge_config::TEdgeConfigLocation,
     ) -> Result<RestartManagerConfig, tedge_config::TEdgeConfigError> {
-        let tedge_config = tedge_config::TEdgeConfig::new(tedge_config_location.clone())?;
+        let tedge_config = tedge_config::TEdgeConfig::try_new(tedge_config_location.clone())?;
 
         Ok(RestartManagerConfig {
             device_topic_id: device_topic_id.clone(),

crates/core/tedge_agent/src/software_manager/actor.rs

@@ -325,7 +325,7 @@ impl SoftwareManagerActor {
 fn get_default_plugin(
     config_location: &tedge_config::TEdgeConfigLocation,
 ) -> Result<Option<SoftwareType>, TEdgeConfigError> {
-    let tedge_config = tedge_config::TEdgeConfig::new(config_location.clone())?;
+    let tedge_config = tedge_config::TEdgeConfig::try_new(config_location.clone())?;
 
     Ok(tedge_config
         .software

crates/core/tedge_agent/src/software_manager/config.rs

@@ -17,7 +17,7 @@ impl SoftwareManagerConfig {
     pub fn from_tedge_config(
         tedge_config_location: &TEdgeConfigLocation,
     ) -> Result<SoftwareManagerConfig, tedge_config::TEdgeConfigError> {
-        let tedge_config = tedge_config::TEdgeConfig::new(tedge_config_location.clone())?;
+        let tedge_config = tedge_config::TEdgeConfig::try_new(tedge_config_location.clone())?;
         let config_dir = &tedge_config_location.tedge_config_root_path;
 
         let default_plugin_type = tedge_config

crates/core/tedge_agent/src/tedge_operation_converter/config.rs

@@ -16,7 +16,7 @@ impl OperationConfig {
         device_topic_id: &EntityTopicId,
         tedge_config_location: &tedge_config::TEdgeConfigLocation,
     ) -> Result<OperationConfig, tedge_config::TEdgeConfigError> {
-        let tedge_config = tedge_config::TEdgeConfig::new(tedge_config_location.clone())?;
+        let tedge_config = tedge_config::TEdgeConfig::try_new(tedge_config_location.clone())?;
 
         Ok(OperationConfig {
             mqtt_schema: MqttSchema::with_root(tedge_config.mqtt.topic_root.clone()),