Skip to content

Commit a36f0b2

Browse files
committed
Log connected only on connack
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
1 parent 172caab commit a36f0b2

File tree

1 file changed

+9
-4
lines changed
  • crates/extensions/tedge_mqtt_bridge/src

1 file changed

+9
-4
lines changed

crates/extensions/tedge_mqtt_bridge/src/lib.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,21 +340,26 @@ impl<'a> BridgeHealth<'a> {
340340
last_err: Some("dummy error".into()),
341341
}
342342
}
343+
343344
async fn update(
344345
&mut self,
345346
result: &NotificationRes,
346347
companion_bridge_half: &mut BidirectionalChannelHalf<Option<Publish>>,
347348
) {
348349
let name = self.name;
349350
let (err, health_payload) = match result {
350-
Ok(_) => (None, MQTT_BRIDGE_UP_PAYLOAD),
351+
Ok(event) => {
352+
if let Event::Incoming(Incoming::ConnAck(_)) = event {
353+
info!("MQTT bridge connected to {name} broker")
354+
}
355+
(None, MQTT_BRIDGE_UP_PAYLOAD)
356+
}
351357
Err(err) => (Some(err.to_string()), MQTT_BRIDGE_DOWN_PAYLOAD),
352358
};
353359

354360
if self.last_err != err {
355-
match &err {
356-
None => info!("MQTT bridge connected to {name} broker"),
357-
Some(err) => error!("MQTT bridge failed to connect to {name} broker: {err}"),
361+
if let Some(err) = &err {
362+
error!("MQTT bridge failed to connect to {name} broker: {err}")
358363
}
359364
self.last_err = err;
360365

0 commit comments

Comments
 (0)