fix(controller): fix error undefined when generate controller

Author: thewalkingcoder

src/Command/MakeTwcController.php

@@ -13,13 +13,16 @@
 
 use Doctrine\Common\Annotations\Annotation;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Bundle\MakerBundle\ConsoleStyle;
 use Symfony\Bundle\MakerBundle\DependencyBuilder;
 use Symfony\Bundle\MakerBundle\FileManager;
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
 use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
+use Symfony\Bundle\MakerBundle\Maker\Common\CanGenerateTestsTrait;
 use Symfony\Bundle\MakerBundle\Str;
+use Symfony\Bundle\MakerBundle\Util\ClassSource\Model\ClassData;
 use Symfony\Bundle\MakerBundle\Util\PhpCompatUtil;
 use Symfony\Bundle\MakerBundle\Util\UseStatementGenerator;
 use Symfony\Bundle\TwigBundle\TwigBundle;
@@ -36,10 +39,15 @@
 final class MakeTwcController extends AbstractMaker
 {
 
+    use CanGenerateTestsTrait;
+
+    private bool $isInvokable;
+    private ClassData $controllerClassData;
+    private bool $usesTwigTemplate;
+    private string $twigTemplatePath;
 
     public function __construct(
         private ContextGenerator $contextGenerator,
-        private FileManager $fileManager,
         private ?PhpCompatUtil $phpCompatUtil = null,
 
     ) {
@@ -71,9 +79,99 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
             ->addOption('invokable', 'i', InputOption::VALUE_NONE, 'Use this option to create an invokable controller')
             ->addOption('context', 'c', InputOption::VALUE_OPTIONAL, 'your context config to generate on your target')
         ;
+        $this->configureCommandWithTestsOption($command);
+    }
+
+    public function interact(InputInterface $input, ConsoleStyle $io, Command $command): void
+    {
+        $this->usesTwigTemplate = $this->isTwigInstalled() && !$input->getOption('no-template');
+        $this->isInvokable = (bool) $input->getOption('invokable');
+
+        $controllerClass = $input->getArgument('controller-class');
+        $controllerClassName = \sprintf('Controller\%s', $controllerClass);
+
+        $context = $input->getOption('context');
+
+        $namespaceContext = $this->contextGenerator->classNameByContext(
+            Support::CONTROLLER,
+            Str::addSuffix($controllerClass, 'Controller'),
+            $context
+        );
+
+        // If the class name provided is absolute, we do not assume it will live in src/Controller
+        // e.g. src/Custom/Location/For/MyController instead of src/Controller/MyController
+        if ($isAbsoluteNamespace = '\\' === $controllerClass[0]) {
+            $controllerClassName = substr($controllerClass, 1);
+        }
+
+        $this->controllerClassData = ClassData::create(
+            class: $namespaceContext,
+            suffix: 'Controller',
+            extendsClass: AbstractController::class,
+            useStatements: [
+                $this->usesTwigTemplate ? Response::class : JsonResponse::class,
+                \Symfony\Component\Routing\Attribute\Route::class,
+            ]
+        );
+
+        // Again if the class name is absolute, lets not make assumptions about where the twig template
+        // should live. E.g. templates/custom/location/for/my_controller.html.twig instead of
+        // templates/my/controller.html.twig. We do however remove the root_namespace prefix in either case
+        // so we don't end up with templates/app/my/controller.html.twig
+        $templateName = $this->controllerClassData->getFullClassName(withoutRootNamespace: true, withoutSuffix: true);
+
+        $dir = $this->contextGenerator->getDirTemplateByContext('template', $context);
+        // Convert the twig template name into a file path where it will be generated.
+        $this->twigTemplatePath = \sprintf('%s%s', $dir, $this->isInvokable ? '.html.twig' : '/index.html.twig');
+
+        $this->interactSetGenerateTests($input, $io);
     }
 
     public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
+    {
+        $controllerPath = $generator->generateClassFromClassData($this->controllerClassData, 'controller/Controller.tpl.php', [
+            'route_path' => Str::asRoutePath($this->controllerClassData->getClassName(relative: true, withoutSuffix: true)),
+            'route_name' => Str::AsRouteName($this->controllerClassData->getClassName(relative: true, withoutSuffix: true)),
+            'method_name' => $this->isInvokable ? '__invoke' : 'index',
+            'with_template' => $this->usesTwigTemplate,
+            'template_name' => $this->twigTemplatePath,
+        ], true);
+
+        if ($this->usesTwigTemplate) {
+            $generator->generateTemplate(
+                $this->twigTemplatePath,
+                'controller/twig_template.tpl.php',
+                [
+                    'controller_path' => $controllerPath,
+                    'root_directory' => $generator->getRootDirectory(),
+                    'class_name' => $this->controllerClassData->getClassName(),
+                ]
+            );
+        }
+
+        if ($this->shouldGenerateTests()) {
+            $testClassData = ClassData::create(
+                class: \sprintf('Tests\Controller\%s', $this->controllerClassData->getClassName(relative: true, withoutSuffix: true)),
+                suffix: 'ControllerTest',
+                extendsClass: WebTestCase::class,
+            );
+
+            $generator->generateClassFromClassData($testClassData, 'controller/test/Test.tpl.php', [
+                'route_path' => Str::asRoutePath($this->controllerClassData->getClassName(relative: true, withoutSuffix: true)),
+            ]);
+
+            if (!class_exists(WebTestCase::class)) {
+                $io->caution('You\'ll need to install the `symfony/test-pack` to execute the tests for your new controller.');
+            }
+        }
+
+        $generator->writeChanges();
+
+        $this->writeSuccessMessage($io);
+        $io->text('Next: Open your new controller class and add some pages!');
+    }
+
+    public function generate1(InputInterface $input, ConsoleStyle $io, Generator $generator): void
     {
         $controllerClass = $input->getArgument('controller-class');
         $context = $input->getOption('context');

src/Command/MakeTwcEntity.php

@@ -60,11 +60,10 @@ final class MakeTwcEntity extends AbstractMaker implements InputAwareMakerInterf
     public function __construct(
         private FileManager $fileManager,
         private DoctrineHelper $doctrineHelper,
+        ContextGenerator $contextGenerator,
         ?string $projectDirectory = null,
         ?Generator $generator = null,
         ?EntityClassGenerator $entityClassGenerator = null,
-        ContextGenerator $contextGenerator,
-
     ) {
         $this->contextGenerator = $contextGenerator;
 

src/Resources/config/services.yaml

@@ -7,7 +7,6 @@ services:
       Twc\MakerBundle\Command\MakeTwcController:
         arguments:
           - '@Twc\MakerBundle\ContextGenerator'
-          - '@maker.file_manager'
         tags:
           - { name: 'maker.command'}
 
@@ -62,9 +61,9 @@ services:
         arguments:
           - '@maker.file_manager'
           - '@maker.doctrine_helper'
+          - '@Twc\MakerBundle\ContextGenerator'
           - '%kernel.project_dir%'
           - '@maker.generator'
           - '@Twc\MakerBundle\Doctrine\EntityClassGenerator'
-          - '@Twc\MakerBundle\ContextGenerator'
         tags:
           - { name: 'maker.command'}