clean up variable names

spawnia · spawnia · commit 58a32e656549 · 2025-04-08T14:30:35.000+02:00
diff --git a/src/Rules/UseSafeCallablesRule.php b/src/Rules/UseSafeCallablesRule.php
@@ -28,15 +28,15 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        $name = $node->getName();
-        if (!$name instanceof Node\Name) {
+        $nodeName = $node->getName();
+        if (!$nodeName instanceof Node\Name) {
             return [];
         }
-        $functionName = $name->toString();
+        $functionName = $nodeName->toString();
         $unsafeFunctions = FunctionListLoader::getFunctionList();
 
         if (isset($unsafeFunctions[$functionName])) {
-            return [new SafeFunctionRuleError($name, $node->getStartLine())];
+            return [new SafeFunctionRuleError($nodeName, $node->getStartLine())];
         }
 
         return [];
diff --git a/src/Rules/UseSafeFunctionsRule.php b/src/Rules/UseSafeFunctionsRule.php
@@ -30,11 +30,11 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        $name = $node->name;
-        if (!$name instanceof Node\Name) {
+        $nodeName = $node->name;
+        if (!$nodeName instanceof Node\Name) {
             return [];
         }
-        $functionName = $name->toString();
+        $functionName = $nodeName->toString();
         $unsafeFunctions = FunctionListLoader::getFunctionList();
 
         if (isset($unsafeFunctions[$functionName])) {
@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array
                 return [];
             }
 
-            return [new SafeFunctionRuleError($name, $node->getStartLine())];
+            return [new SafeFunctionRuleError($nodeName, $node->getStartLine())];
         }
 
         return [];

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,15 @@ public function getNodeType(): string`
`28`	`28`
`29`	`29`	`public function processNode(Node $node, Scope $scope): array`
`30`	`30`	`{`
`31`		`- $name = $node->getName();`
`32`		`- if (!$name instanceof Node\Name) {`
	`31`	`+ $nodeName = $node->getName();`
	`32`	`+ if (!$nodeName instanceof Node\Name) {`
`33`	`33`	`return [];`
`34`	`34`	`}`
`35`		`- $functionName = $name->toString();`
	`35`	`+ $functionName = $nodeName->toString();`
`36`	`36`	`$unsafeFunctions = FunctionListLoader::getFunctionList();`
`37`	`37`
`38`	`38`	`if (isset($unsafeFunctions[$functionName])) {`
`39`		`- return [new SafeFunctionRuleError($name, $node->getStartLine())];`
	`39`	`+ return [new SafeFunctionRuleError($nodeName, $node->getStartLine())];`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`return [];`
Original file line number	Diff line number	Diff line change
`@@ -30,11 +30,11 @@ public function getNodeType(): string`
`30`	`30`
`31`	`31`	`public function processNode(Node $node, Scope $scope): array`
`32`	`32`	`{`
`33`		`- $name = $node->name;`
`34`		`- if (!$name instanceof Node\Name) {`
	`33`	`+ $nodeName = $node->name;`
	`34`	`+ if (!$nodeName instanceof Node\Name) {`
`35`	`35`	`return [];`
`36`	`36`	`}`
`37`		`- $functionName = $name->toString();`
	`37`	`+ $functionName = $nodeName->toString();`
`38`	`38`	`$unsafeFunctions = FunctionListLoader::getFunctionList();`
`39`	`39`
`40`	`40`	`if (isset($unsafeFunctions[$functionName])) {`
`@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array`
`63`	`63`	`return [];`
`64`	`64`	`}`
`65`	`65`
`66`		`- return [new SafeFunctionRuleError($name, $node->getStartLine())];`
	`66`	`+ return [new SafeFunctionRuleError($nodeName, $node->getStartLine())];`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`return [];`