Skip to content

Commit 150031e

Browse files
authored
Merge pull request #36 from Jean85/fix-ci
Fix broken test
2 parents ccd3d55 + 593271e commit 150031e

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"require": {
1313
"php": "^7.4 || ^8.0",
1414
"phpstan/phpstan": "^2.0",
15-
"thecodingmachine/safe": "^1.0 || ^2.0"
15+
"thecodingmachine/safe": "^1.0 || ^2.0",
16+
"nikic/php-parser": "^5"
1617
},
1718
"require-dev": {
1819
"phpunit/phpunit": "^9.6",

tests/Rules/CallMethodRuleTest.php

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use PHPStan\Rules\Methods\MethodCallCheck;
99
use PHPStan\Rules\NullsafeCheck;
1010
use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
11+
use PHPStan\Rules\Properties\PropertyReflectionFinder;
1112
use PHPStan\Rules\Rule;
1213
use PHPStan\Rules\RuleLevelHelper;
1314
use PHPStan\Testing\RuleTestCase;
@@ -17,15 +18,31 @@ class CallMethodRuleTest extends RuleTestCase
1718
{
1819
protected function getRule(): Rule
1920
{
20-
$reflectionProvider = $this->createReflectionProvider();
21-
$ruleLevelHelper = new RuleLevelHelper($reflectionProvider, true, true, true, false);
21+
$reflectionProvider = self::createReflectionProvider();
22+
$ruleLevelHelper = new RuleLevelHelper($reflectionProvider, true, true, true, true, false, true);
23+
2224
return new CallMethodsRule(
23-
new MethodCallCheck($reflectionProvider, $ruleLevelHelper, true, true),
24-
new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), new UnresolvableTypeHelper(), true, false, false, false)
25+
new MethodCallCheck(
26+
$reflectionProvider,
27+
$ruleLevelHelper,
28+
true,
29+
true
30+
),
31+
new FunctionCallParametersCheck(
32+
$ruleLevelHelper,
33+
new NullsafeCheck(),
34+
new PhpVersion(PHP_VERSION_ID),
35+
new UnresolvableTypeHelper(),
36+
new PropertyReflectionFinder(),
37+
true,
38+
true,
39+
true,
40+
true
41+
)
2542
);
2643
}
2744

28-
public function testSafePregReplace()
45+
public function testSafePregReplace(): void
2946
{
3047
// FIXME: this rule actually runs code but will always return no error because the rule executed is not the correct one.
3148
// This provides code coverage but assert is not ok.

0 commit comments

Comments
 (0)