Adds interface for config

Author: lakhansamani

dist/index.js

@@ -27,7 +27,8 @@
   "homepage": "https://github.com/thebigredgeek/apollo-errors#readme",
   "dependencies": {
     "assert": "^1.4.1",
-    "extendable-error": "^0.1.5"
+    "extendable-error": "^0.1.5",
+    "install": "^0.10.1"
   },
   "devDependencies": {
     "babel-cli": "^6.18.0",

dist/index.js.map

@@ -1,6 +1,5 @@
 import * as assert from 'assert';
 import ExtendableError from 'extendable-error';
-
 const isString = d => Object.prototype.toString.call(d) === '[object String]';
 const isObject = d => Object.prototype.toString.call(d) === '[object Object]';
 interface ErrorConfig {
@@ -9,7 +8,6 @@ interface ErrorConfig {
   data: any,
   options: any,
 }
-
 class ApolloError extends ExtendableError {
   name: string;
   message: string;
@@ -19,12 +17,12 @@ class ApolloError extends ExtendableError {
   locations: any;
   _showLocations: any;
   constructor (name, config: ErrorConfig) {
-    const t = (config && config.time_thrown) || (new Date()).toISOString();
-    const d = (config && config.data || {})
-    const m = (config && config.message) || '';
-    const opts = ((config && config.options) || {})
-
-    super(m);
+    super((config && config.message) || '');
+    const t = (arguments[2] && arguments[2].time_thrown) || (new Date()).toISOString();
+    const m = (arguments[2] && arguments[2].message) || '';
+    const configData = (arguments[2] && arguments[2].data) || {};
+    const d = {...this.data, ...configData}
+    const opts = ((arguments[2] && arguments[2].options) || {})
 
     this.name = name;
     this.message = m;
@@ -43,20 +41,17 @@ class ApolloError extends ExtendableError {
       path,
       locations
     };
-
     if (_showLocations) {
       error.locations = locations;
       error.path = path;
     }
-
     return error;
   }
 }
 
 export const isInstance = e => e instanceof ApolloError;
 
 export const createError = (name, config: ErrorConfig) => {
-  console.log('config', config);
   assert(isObject(config), 'createError requires a config object as the second parameter');
   assert(isString(config.message), 'createError requires a "message" property on the config object passed as the second parameter');
   const e = ApolloError.bind(null, name, config);

package.json

@@ -15,27 +15,28 @@ describe('createError', () => {
         },
         options: {
           showLocations: false,
-          showPath: true,
+          showPath: false,
         },
       });
       const iso = new Date().toISOString();
-
       const e = new FooError({
         message: 'A foo 2.0 error has occurred',
         data: {
+          hello: 'world',
           foo: 'bar'
         },
         options: {
           showLocations: true,
-          showPath: false,
+          showPath: true,
         },
       });
-      const { message, name, time_thrown, data } = e.serialize();
 
+      const { message, name, time_thrown, data } = e.serialize();
       expect(message).to.equal('A foo 2.0 error has occurred');
       expect(name).to.equal('FooError');
       expect(time_thrown).to.equal(e.time_thrown);
       expect(data).to.eql({
+        hello: 'world',
         foo: 'bar'
       });
     });
@@ -86,7 +87,6 @@ describe('formatError', () => {
             oh: 'shit'
           }
         });
-
         const s = formatError({
           originalError: e
         }, false);