feat: add guesser arg
#101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The HelloWorld contract is so simple as to be obtuse. It's confusing
in its pointlessness. And it doesn't show off anything interesting
about blockchain programming.
- GuessTheNumber represents a most-basic starting point for a contract
that can show some interesting blockchain functionality. Already, it
shows:
- storing data
- constructor
- admin-guarded methods
- forthcoming contracttrait composability pattern
(stellar/rs-soroban-sdk#1522)
- forthcoming admin SEP (https://github.com/AhaLabs/admin-sep)
- This represents the probable starting point for the contract. In its
current state, it has many purposeful ommissions/shortcomings.
- `unwrap` in `guess` causes error if admin did not yet call `reset`;
need to extract number-setting logic to separate function and call
it in both `reset` and `__constructor`
- no XLM is currently owned by contract or awarded to winning guess;
need to require XLM transfer from admin in `reset` as well as
nominal fee to call `guess` (which gets added to pot)
- can inspect contract storage to see stored number; need to obfuscate
with fun crypto tricks
- These shortcomings would be addressed through an onboarding tutorial
in the Stellar docs and maybe in the UI of the app itself, which so
far has some very basic info about interacting with the contract
chadoh
commented
Sep 15, 2025
|
|
||
| /// Guess a number between 1 and 10 | ||
| pub fn guess(env: &Env, a_number: u64) -> bool { | ||
| pub fn guess(env: &Env, guesser: Address, a_number: u64) -> bool { |
There was a problem hiding this comment.
The tutorial should explain why you need to pass guesser as an argument, instead of just requiring that the invoker—whoever they may be—signed the transaction. soroban-sdk is ~ToO fLeXiBLe~ to allow you to just check who the invoker is. This is unexpected! Make sure people understand it.
chadoh
commented
Sep 15, 2025
chadoh
force-pushed
the
feat/guess-the-number
branch
from
135ba07 to
6cd970d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates a reasonable Step Two of the tutorial