Skip to content

Commit fad52ba

Browse files
author
MarcoFalke
committed
fuzz: Rework addr fuzzing
* Replace ConsumeDeserializationParams with V1, because V2 is unconditionally checked as well. * Also fuzz CAddress::Format::Disk in the address_deserialize fuzz target.
1 parent fa5b6d2 commit fad52ba

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/test/fuzz/deserialize.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ FUZZ_TARGET(netaddr_deserialize, .init = initialize_deserialize)
252252
if (!maybe_na) return;
253253
const CNetAddr& na{*maybe_na};
254254
if (na.IsAddrV1Compatible()) {
255-
AssertEqualAfterSerializeDeserialize(na, ConsumeDeserializationParams<CNetAddr::SerParams>(fdp));
255+
AssertEqualAfterSerializeDeserialize(na, CNetAddr::V1);
256256
}
257257
AssertEqualAfterSerializeDeserialize(na, CNetAddr::V2);
258258
}
@@ -264,7 +264,7 @@ FUZZ_TARGET(service_deserialize, .init = initialize_deserialize)
264264
if (!maybe_s) return;
265265
const CService& s{*maybe_s};
266266
if (s.IsAddrV1Compatible()) {
267-
AssertEqualAfterSerializeDeserialize(s, ConsumeDeserializationParams<CNetAddr::SerParams>(fdp));
267+
AssertEqualAfterSerializeDeserialize(s, CNetAddr::V1);
268268
}
269269
AssertEqualAfterSerializeDeserialize(s, CNetAddr::V2);
270270
if (ser_params.enc == CNetAddr::Encoding::V1) {
@@ -279,8 +279,8 @@ FUZZ_TARGET_DESERIALIZE(messageheader_deserialize, {
279279
FUZZ_TARGET(address_deserialize, .init = initialize_deserialize)
280280
{
281281
FuzzedDataProvider fdp{buffer.data(), buffer.size()};
282-
const auto ser_enc{ConsumeDeserializationParams<CNetAddr::SerParams>(fdp)};
283-
const auto maybe_a{ConsumeDeserializable<CAddress>(fdp, CAddress::SerParams{{ser_enc}, CAddress::Format::Network})};
282+
const auto ser_enc{ConsumeDeserializationParams<CAddress::SerParams>(fdp)};
283+
const auto maybe_a{ConsumeDeserializable<CAddress>(fdp, ser_enc)};
284284
if (!maybe_a) return;
285285
const CAddress& a{*maybe_a};
286286
// A CAddress in V1 mode will roundtrip

0 commit comments

Comments
 (0)