bitcoin-tx: Make replaceable value optional

kashifs · kashifs · commit c2b836b119ee · 2023-12-04T16:14:00.000-05:00
diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp
@@ -223,8 +223,8 @@ static void MutateTxLocktime(CMutableTransaction& tx, const std::string& cmdVal)
 static void MutateTxRBFOptIn(CMutableTransaction& tx, const std::string& strInIdx)
 {
     // parse requested index
-    int64_t inIdx;
-    if (!ParseInt64(strInIdx, &inIdx) || inIdx < 0 || inIdx >= static_cast<int64_t>(tx.vin.size())) {
+    int64_t inIdx = -1;
+    if (strInIdx != "" && (!ParseInt64(strInIdx, &inIdx) || inIdx < 0 || inIdx >= static_cast<int64_t>(tx.vin.size()))) {
         throw std::runtime_error("Invalid TX input index '" + strInIdx + "'");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -223,8 +223,8 @@ static void MutateTxLocktime(CMutableTransaction& tx, const std::string& cmdVal)`
`223`	`223`	`static void MutateTxRBFOptIn(CMutableTransaction& tx, const std::string& strInIdx)`
`224`	`224`	`{`
`225`	`225`	`// parse requested index`
`226`		`- int64_t inIdx;`
`227`		`- if (!ParseInt64(strInIdx, &inIdx) \|\| inIdx < 0 \|\| inIdx >= static_cast<int64_t>(tx.vin.size())) {`
	`226`	`+ int64_t inIdx = -1;`
	`227`	`+ if (strInIdx != "" && (!ParseInt64(strInIdx, &inIdx) \|\| inIdx < 0 \|\| inIdx >= static_cast<int64_t>(tx.vin.size()))) {`
`228`	`228`	`throw std::runtime_error("Invalid TX input index '" + strInIdx + "'");`
`229`	`229`	`}`
`230`	`230`