Skip to content

Commit a7484be

Browse files
committed
Merge bitcoin#29059: Revert "ci: Only run functional tests on windows in master"
7b22cd8 Revert "ci: Only run functional tests on windows in master" (Hennadii Stepanov) Pull request description: This PR reverts commit aba4a58 from bitcoin#28567. The Windows-specific code received [quality](bitcoin#28486) and [performance](bitcoin#29045) improvements recently. So there are no reasons to skip functional tests in PRs anymore. In my own repo, I've run the GHA Windows job more than 100 times with no failure. ACKs for top commit: maflcko: lgtm ACK 7b22cd8 TheCharlatan: ACK 7b22cd8 Tree-SHA512: 1e8687e8efe12db506e7cd2d5df9e48b5acb98a339f84684dd0fd67280e22227e2a5a206f1108b09e49038fab7a3ca2ffbd985677f00048c0962b39b2b9a2ba5
2 parents 60f6773 + 7b22cd8 commit a7484be

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,6 @@ jobs:
282282
run: py -3 test\util\rpcauth-test.py
283283

284284
- name: Run functional tests
285-
# Don't run functional tests for pull requests.
286-
# The test suit regularly fails to complete in windows native github
287-
# actions as a child process stops making progress. The root cause has
288-
# not yet been determined.
289-
# Discussed in https://github.com/bitcoin/bitcoin/pull/28509
290-
if: github.event_name != 'pull_request'
291-
run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR --extended
285+
env:
286+
TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }}
287+
run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR $env:TEST_RUNNER_EXTRA

0 commit comments

Comments
 (0)