Skip to content

Commit 8431a19

Browse files
committed
Merge bitcoin#29068: test: Actually fail when a python unit test fails
fa0534d test: Actually fail when a python unit test fails (MarcoFalke) Pull request description: Currently python unit test failures are ignored. Fix this. ACKs for top commit: theStack: ACK fa0534d BrandonOdiwuor: ACK fa0534d Tree-SHA512: c136be4c8d861d966f380e04d5d14b711b90c4011101302dae1332496e493207c5c673927586ed35b02b61a0b050bf45053a31e6ff766ec52f1d054caf0985e2
2 parents 54f6756 + fa0534d commit 8431a19

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/functional/test_runner.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -565,8 +565,7 @@ def run_tests(*, test_list, src_dir, build_dir, tmpdir, jobs=1, enable_coverage=
565565
test_framework_tests.addTest(unittest.TestLoader().loadTestsFromName("test_framework.{}".format(module)))
566566
result = unittest.TextTestRunner(verbosity=1, failfast=True).run(test_framework_tests)
567567
if not result.wasSuccessful():
568-
logging.debug("Early exiting after failure in TestFramework unit tests")
569-
sys.exit(False)
568+
sys.exit("Early exiting after failure in TestFramework unit tests")
570569

571570
flags = ['--cachedir={}'.format(cache_dir)] + args
572571

0 commit comments

Comments
 (0)