fuzz: disable BnB when SFFO is enabled

furszy · furszy · commit 576bee88fd36 · 2023-12-11T23:40:21.000-03:00
diff --git a/src/wallet/test/fuzz/coinselection.cpp b/src/wallet/test/fuzz/coinselection.cpp
@@ -116,7 +116,8 @@ FUZZ_TARGET(coinselection)
     }
 
     // Run coinselection algorithms
-    auto result_bnb = SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
+    auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :
+                      SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
     if (result_bnb) {
         assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);
         assert(result_bnb->GetSelectedValue() >= target);

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,8 @@ FUZZ_TARGET(coinselection)`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`// Run coinselection algorithms`
`119`		`- auto result_bnb = SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);`
	`119`	`+ auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :`
	`120`	`+ SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);`
`120`	`121`	`if (result_bnb) {`
`121`	`122`	`assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);`
`122`	`123`	`assert(result_bnb->GetSelectedValue() >= target);`