bug: Grammar issue with reading time

[soonernotfaster]

Expected Behavior

Enabling show_reading_time for en language code displays reading time as 3 minute read

Current Behavior

Reading time is displayed as 3 minutes read.

Possible Solution

Updating grammar in

gohugo-theme-ananke/i18n/en.toml

Line 42 in ff04bf8

other = "{{ .Count }} minutes read"

would resolve the issue.

Steps to Reproduce

1. In a site that has blog posts
2. Set params.show_reading_time = true in config.toml
3. Start dev server
4. Go to any post with browser language set to en
5. See reading time is incorrectly pluralized

The bigger picture (we need context)

N/A

Hugo Config

[soonernotfaster]

@davidsneighbour, I'm happy to put a PR up for this.

[davidsneighbour]

We are in a minefield here. The fact that this wasn't an issue before tells me that both ways of writing are in some form accepted ways of writing that.

a 3 minute read - the reading of this requires three minutes
a 3 minutes read - after 3 minutes you are done reading this

I need to let this simmer and think about it and probably research, what "grammar nazis" have to say about this. If it's an AE vs BE thing we can add en_us and en_uk translations.

To fix this for your own use case you can create or add to an i18n/en.toml in your projects root folder and add the edited contents of the themes language file there.

[soonernotfaster]

I can totally see that. Are there tasks you are open to receiving contributions for, to help lighten the load?

I need to let this simmer and think about it and probably research, what "grammar nazis" have to say about this. If it's an AE vs BE thing we can add en_us and en_uk translations.

I don't believe either is correct grammar in UK or US english. Folks have either taken the override path to fix the grammar issue, or this feature is not used often with this theme.

💭 Who have I become that I am quibbling over grammar 😅

[davidsneighbour]

💭 Who have I become that I am quibbling over grammar 😅

That's an easy rabbit hole to fall in :D

Ok. After some research, I found that there is a single correct form to write this: yours. I am wrong. The "unit" part has to be singular, we are "measuring" something. A 5 minute read. A 20 year old person. A five-course menu. The "number + unit" form here is a "compound adjective".

So be it :) Feel free to push an MR with this, or I'll add in a bit.

That looks much different in German (my other primary language), but I am tired of researching that.

PS: would we have used "Reading time: x minute(s)" this could have been avoided...