Fixed #18. Removed readOnlyBuffer. It was causing problems on Android 7

Author: andresoviedo

README.md

@@ -12,9 +12,10 @@ The purpose of this application is to learn and share how to draw using OpenGL l
 * STereoLithography format (STL): https://en.wikipedia.org/wiki/STL_(file_format)
 
 
-News (17/04/2017)
+News (23/04/2017)
 =================
 
+* Fixed #18: Removed asReadOnlyBuffer() - not working on Android 7
 * Enhancement #17: Added support for TLS format
 * Fixed #16: Toogle point drawing
 * Fixed #15: Toggle rotating light
@@ -125,7 +126,10 @@ ChangeLog
 
 (f) fixed, (i) improved, (n) new feature
 
-- 1.3.1 (17/04/2017)
+- 1.3.1 (23/04/2017)
+ - (f) #18: Removed asReadOnlyBuffer() because it is causing IndexOutOfBounds on Android 7
+
+- 1.3.0 (17/04/2017)
   - (n) #17: Added support for STL files
   - (n) #17: Asynchronous building of model so the build rendering is previewed
   - (f) #17: Added Toasts to buttons to show current state

app/build/outputs/apk/app-release.apk

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="org.andresoviedo.dddmodel2"
-    android:versionCode="10"
-    android:versionName="1.3.0" >
+    android:versionCode="11"
+    android:versionName="1.3.1" >
 
     <uses-sdk
         android:minSdkVersion="8"

app/src/main/AndroidManifest.xml

@@ -460,8 +460,8 @@ public static Object3DData generateArrays(AssetManager assets, Object3DData obj)
 		obj.setDrawUsingArrays(true);
 
 		Log.i("Object3DBuilder", "Populating vertex array...");
-		final FloatBuffer vertexBuffer = obj.getVerts().asReadOnlyBuffer();
-		final IntBuffer indexBuffer = faces.getIndexBuffer().asReadOnlyBuffer();
+		final FloatBuffer vertexBuffer = obj.getVerts();
+		final IntBuffer indexBuffer = faces.getIndexBuffer();
 		for (int i = 0; i < faces.getVerticesReferencesCount(); i++) {
 			vertexArrayBuffer.put(i*3,vertexBuffer.get(indexBuffer.get(i) * 3));
 			vertexArrayBuffer.put(i*3+1,vertexBuffer.get(indexBuffer.get(i) * 3 + 1));
@@ -476,7 +476,7 @@ public static Object3DData generateArrays(AssetManager assets, Object3DData obj)
 		obj.setVertexNormalsArrayBuffer(vertexNormalsArrayBuffer);
 
 		// build file normals
-		final FloatBuffer vertexNormalsBuffer = obj.getNormals().asReadOnlyBuffer();
+		final FloatBuffer vertexNormalsBuffer = obj.getNormals();
 		if (vertexNormalsBuffer.capacity() > 0) {
 			Log.i("Object3DBuilder", "Populating normals buffer...");
 			for (int n=0; n<faces.facesNormIdxs.size(); n++) {
@@ -706,7 +706,7 @@ public static Object3DData buildWireframe(Object3DData objData) {
 
 			try {
 				Log.i("Object3DBuilder", "Building wireframe...");
-				IntBuffer drawBuffer = objData.getDrawOrder().asReadOnlyBuffer();
+				IntBuffer drawBuffer = objData.getDrawOrder();
 				IntBuffer wireframeDrawOrder = createNativeByteBuffer(drawBuffer.capacity() * 2 * 4).asIntBuffer();
 				for (int i = 0; i < drawBuffer.capacity(); i += 3) {
 					int v0 = drawBuffer.get(i);