Skip to content

Commit 8637c41

Browse files
authored
Merge pull request #3 from TerraHubCorp/google-first-demo
change google_account_id to google_service_account_name
2 parents b091c1a + 7b090a8 commit 8637c41

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

.terrahub.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ terraform:
1212
google_project_id: project-123456789012
1313
google_region: us-central1
1414
google_org_id: 123456789012
15-
google_account_id: demo-team
15+
google_service_account_name: demo-team
1616
google_billing_account: 123456-ABCDEF-ZYXWVU
1717
google_location_id: us-central
1818
version: 0.11.7

project_service_account/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Allows management of a Google Cloud Platform service account
77
| Name | Description | Type | Default | Required |
88
|------|-------------|:----:|:-----:|:-----:|
99
|google_service_account_display_name|The display name for the service account. Can be updated without creating a new resource.|string|project-service-account|No|
10-
|google_account_id|The service account ID. Changing this forces a new service account to be created.|string||Yes|
10+
|google_service_account_name|The service account Name. Changing this forces a new service account to be created.|string||Yes|
1111
|google_project_id|The ID of the project that the service account will be created in. Defaults to the provider project configuration.|string||Yes|
1212

1313
## output parameters

project_service_account/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
resource "google_service_account" "project_service_account" {
22
display_name = "${var.google_service_account_display_name}"
3-
account_id = "${var.google_account_id}"
3+
account_id = "${var.google_service_account_name}"
44
project = "${var.google_project_id}"
55
}

project_service_account/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ variable "google_service_account_display_name" {
77
description = "The display name for the service account. Can be updated without creating a new resource."
88
}
99

10-
variable "google_account_id" {
11-
description = "The service account ID. Changing this forces a new service account to be created."
10+
variable "google_service_account_name" {
11+
description = "The service account NAME. Changing this forces a new service account to be created."
1212
}
1313

1414
variable "google_project_id" {

project_service_account_key/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Creates and manages service account key-pairs, which allow the user to establish
66

77
| Name | Description | Type | Default | Required |
88
|------|-------------|:----:|:-----:|:-----:|
9-
|google_account_id|The Service account id of the Key Pair. This can be a string in the format {ACCOUNT} or projects/{PROJECT_ID}/serviceAccounts/{ACCOUNT}, where {ACCOUNT} is the email address or unique id of the service account. If the {ACCOUNT} syntax is used, the project will be inferred from the account.|string||Yes|
9+
|google_service_account_name|The Service account name of the Key Pair. This can be a string in the format {ACCOUNT} or projects/{PROJECT_ID}/serviceAccounts/{ACCOUNT}, where {ACCOUNT} is the email address or unique id of the service account. If the {ACCOUNT} syntax is used, the project will be inferred from the account.|string||Yes|
1010
|google_service_account_key_algorithm|The algorithm used to generate the key. KEY_ALG_RSA_2048 is the default algorithm. Valid values are listed at ServiceAccountPrivateKeyType (only used on create)|string|KEY_ALG_RSA_2048|No|
1111
|google_service_account_key_public_key_type|The output format of the public key requested. X509_PEM is the default output format.|string|X509_PEM|No|
1212
|google_service_account_key_private_key_type|The output format of the private key. TYPE_GOOGLE_CREDENTIALS_FILE is the default output format.|string|TYPE_GOOGLE_CREDENTIALS_FILE|No|

project_service_account_key/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
resource "google_service_account_key" "project_service_account_key" {
2-
service_account_id = "${var.google_account_id}@${var.google_project_id}.iam.gserviceaccount.com"
2+
service_account_id = "${var.google_service_account_name}@${var.google_project_id}.iam.gserviceaccount.com"
33
key_algorithm = "${var.google_service_account_key_algorithm}"
44
public_key_type = "${var.google_service_account_key_public_key_type}"
55
private_key_type = "${var.google_service_account_key_private_key_type}"

project_service_account_key/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
#############
44
# top level #
55
#############
6-
variable "google_account_id" {
7-
description = "The Service account id of the Key Pair. This can be a string in the format {ACCOUNT} or projects/{PROJECT_ID}/serviceAccounts/{ACCOUNT}, where {ACCOUNT} is the email address or unique id of the service account. If the {ACCOUNT} syntax is used, the project will be inferred from the account."
6+
variable "google_service_account_name" {
7+
description = "The Service account name of the Key Pair. This can be a string in the format {ACCOUNT} or projects/{PROJECT_ID}/serviceAccounts/{ACCOUNT}, where {ACCOUNT} is the email address or unique id of the service account. If the {ACCOUNT} syntax is used, the project will be inferred from the account."
88
}
99

1010
variable "google_project_id" {

0 commit comments

Comments
 (0)