Merge pull request #1 from azu/fix-empty-reduce

Fix "TypeError: Reduce of empty array with no initial value"

Author: takahashim

.babelrc

@@ -1,4 +1,15 @@
 {
-    "presets": ["es2015"],
-    "plugins": ["add-module-exports"]
+  "presets": [
+    "es2015"
+  ],
+  "plugins": [
+    "add-module-exports"
+  ],
+  "env": {
+    "development": {
+      "presets": [
+        "power-assert"
+      ]
+    }
+  }
 }

package.json

@@ -9,22 +9,23 @@
   },
   "dependencies": {
     "kuromojin": "^1.1.0",
-    "sentence-splitter": "^1.2.0",
+    "sentence-splitter": "^2.0.0",
     "textlint-rule-helper": "^1.1.5",
     "textlint-util-to-string": "^1.2.0"
   },
   "devDependencies": {
     "babel-cli": "^6.5.1",
-    "babel-plugin-add-module-exports": "^0.1.2",
+    "babel-plugin-add-module-exports": "^0.2.0",
     "babel-preset-es2015": "^6.5.0",
-    "espower-babel": "^4.0.1",
+    "babel-preset-power-assert": "^1.0.0",
+    "babel-register": "^6.8.0",
     "mocha": "^2.4.5",
-    "power-assert": "^1.2.0",
-    "textlint": "^5.2.1",
-    "textlint-tester": "^0.4.1"
+    "power-assert": "^1.4.0",
+    "textlint": "^6.6.0",
+    "textlint-tester": "^1.2.0"
   },
   "scripts": {
-    "build": "babel src --out-dir lib --source-maps",
+    "build": "NODE_ENV=production babel src --out-dir lib --source-maps",
     "watch": "babel src --out-dir lib --watch --source-maps",
     "prepublish": "npm run --if-present build",
     "test": "mocha",

src/no-doubled-conjunction.js

@@ -2,7 +2,7 @@
 "use strict";
 import {RuleHelper} from "textlint-rule-helper";
 import {getTokenizer} from "kuromojin";
-import splitSentences, {Syntax as SentenceSyntax} from "sentence-splitter";
+import {split as splitSentences, Syntax as SentenceSyntax} from "sentence-splitter";
 import StringSource from "textlint-util-to-string";
 
 /*
@@ -27,6 +27,11 @@ export default function (context, options = {}) {
             let sentences = splitSentences(text, {
                 charRegExp: /[。\?\!？！]/
             }).filter(isSentenceNode);
+            // if not have a sentence, early return
+            // It is for avoiding error of emptyArray.reduce().
+            if(sentences.length === 0) {
+                return;
+            }
             return getTokenizer().then(tokenizer => {
               const selectConjenction = (sentence) => {
                 let tokens = tokenizer.tokenizeForSentence(sentence.raw);
@@ -43,16 +48,13 @@ export default function (context, options = {}) {
                 }
                 if (current_tokens.length > 0) {
                   if (token && current_tokens[0].surface_form === token.surface_form) {
-                    let originalPosition = source.originalPositionFor({
+                    let originalIndex = source.originalIndexFromPosition({
                       line: sentence.loc.start.line,
                       column: sentence.loc.start.column + (current_tokens[0].word_position - 1)
                     });
                     // padding position
                     var padding = {
-                      line: originalPosition.line - 1,
-                      // matchLastToken.word_position start with 1
-                      // this is padding column start with 0 (== -1)
-                      column: originalPosition.column
+                        index: originalIndex
                     };
                     report(node, new RuleError(`同じ接続詞が連続して使われています。`, padding));
                   }

test/mocha.opts

@@ -1 +1 @@
---compilers js:espower-babel/guess
+--compilers js:babel-register

test/no-doubled-conjunction.js

@@ -1,11 +1,12 @@
-import assert from "power-assert";
 import rule from "../src/no-doubled-conjunction";
 import TextLintTester from "textlint-tester";
 var tester = new TextLintTester();
 tester.run("no-doubled-conjunction", rule, {
     valid: [
         "朝起きた。そして、夜に寝た。",
-        "そして朝起きた。けれど昼は仕事をした。そして夜に寝た。"
+        "そして朝起きた。けれど昼は仕事をした。そして夜に寝た。",
+        "``", // empty Paragraph,
+        "![](path/to/image.png)"// empty image label
     ],
     invalid: [
       {