Skip to content

Commit 151b4b1

Browse files
committed
apply n.breaks regarless or whence breaks-function came
1 parent 78ecf62 commit 151b4b1

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

R/scale-.R

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -743,25 +743,21 @@ ScaleContinuous <- ggproto("ScaleContinuous", Scale,
743743
return(limits[1])
744744
}
745745

746-
# Limits in transformed space need to be converted back to data space
747-
limits <- transformation$inverse(limits)
748-
749-
if (is.waive(self$breaks)) {
750-
if (!is.null(self$n.breaks) && support_nbreaks(transformation$breaks)) {
751-
breaks <- transformation$breaks(limits, self$n.breaks)
746+
if (is.function(breaks)) {
747+
# Limits in transformed space need to be converted back to data space
748+
limits <- transformation$inverse(limits)
749+
if (!is.null(self$n.breaks) && support_nbreaks(breaks)) {
750+
breaks <- breaks(limits, n = self$n.breaks)
752751
} else {
752+
breaks <- breaks(limits)
753753
if (!is.null(self$n.breaks)) {
754754
cli::cli_warn(
755-
"Ignoring {.arg n.breaks}. Use a {.cls transform} object that supports setting number of breaks.",
755+
"Ignoring {.arg n.breaks}. Use a {.cls transform} object or \\
756+
{.arg breaks} function that supports setting number of breaks",
756757
call = self$call
757758
)
758759
}
759-
breaks <- transformation$breaks(limits)
760760
}
761-
} else if (is.function(self$breaks)) {
762-
breaks <- self$breaks(limits)
763-
} else {
764-
breaks <- self$breaks
765761
}
766762

767763
# Breaks in data space need to be converted back to transformed space

0 commit comments

Comments
 (0)