Renamed getBrowser() method to browser() since all other similar methods are declared without the "get" prefix as well

Author: slu-it

webtester-core/src/main/java/info/novatec/testit/webtester/adhoc/AdHocFinder.java

@@ -61,7 +61,7 @@ public AdHocFinder(Browser browser) {
      * @since 2.0
      */
     public AdHocFinder(PageFragment parent) {
-        this.factory = new PageFragmentFactory(parent.getBrowser());
+        this.factory = new PageFragmentFactory(parent.browser());
         this.searchContext = parent.webElement();
     }
 

webtester-core/src/main/java/info/novatec/testit/webtester/css/DefaultStyleChanger.java

@@ -24,7 +24,7 @@ public boolean changeStyleInformation(PageFragment pageFragment, Map<String, Str
 
     private boolean changeStyleWithScript(PageFragment fragment, String script) {
         try {
-            fragment.getBrowser().javaScript().execute(script, fragment);
+            fragment.browser().javaScript().execute(script, fragment);
             return true;
         } catch (WebDriverException e) {
             log.warn("Exception while changing the style information of an page object: {}", e.getMessage());

webtester-core/src/main/java/info/novatec/testit/webtester/internal/ActionTemplate.java

@@ -104,7 +104,7 @@ public static class PageFragmentAction<T extends PageFragment> extends Action<T,
         private Marker marker;
 
         public PageFragmentAction(T subject) {
-            super(subject, subject.getBrowser());
+            super(subject, subject.browser());
             marker = new Marker(new DefaultStyleChanger());
         }
 
@@ -133,7 +133,7 @@ public static class PageFragmentsAction<T extends PageFragment> extends BiAction
         private Marker marker;
 
         public PageFragmentsAction(T subject1, T subject2) {
-            super(subject1, subject2, subject1.getBrowser());
+            super(subject1, subject2, subject1.browser());
             marker = new Marker(new DefaultStyleChanger());
         }
 

webtester-core/src/main/java/info/novatec/testit/webtester/internal/OffersBrowserGetter.java

@@ -14,6 +14,6 @@ public interface OffersBrowserGetter {
      * @since 2.0
      */
     @ReturnsBrowser
-    Browser getBrowser();
+    Browser browser();
 
 }

webtester-core/src/main/java/info/novatec/testit/webtester/markings/Marker.java

@@ -39,7 +39,7 @@ public Marker(StyleChanger styleChanger) {
      * @since 2.0
      */
     public void markAsRead(PageFragment fragment) {
-        Configuration configuration = fragment.getBrowser().configuration();
+        Configuration configuration = fragment.browser().configuration();
         if (configuration.isMarkingsEnabled()) {
             Color backgroundColor = configuration.getMarkingsColorReadBackground();
             Color outlineColor = configuration.getMarkingsColorReadOutline();
@@ -58,7 +58,7 @@ public void markAsRead(PageFragment fragment) {
      * @since 2.0
      */
     public void markAsUsed(PageFragment pageFragment) {
-        Configuration configuration = pageFragment.getBrowser().configuration();
+        Configuration configuration = pageFragment.browser().configuration();
         if (configuration.isMarkingsEnabled()) {
             Color backgroundColor = configuration.getMarkingsColorUsedBackground();
             Color outlineColor = configuration.getMarkingsColorUsedOutline();

webtester-core/src/main/java/info/novatec/testit/webtester/mouse/DefaultMouseDriver.java

@@ -73,7 +73,7 @@ private void perform(PageFragment fragment, BiFunction<Actions, WebElement, Acti
     }
 
     private Actions sequenceFor(PageFragment fragment) {
-        return new Actions(fragment.getBrowser().webDriver());
+        return new Actions(fragment.browser().webDriver());
     }
 
 }

webtester-core/src/main/java/info/novatec/testit/webtester/pagefragments/GenericElement.java

@@ -92,7 +92,7 @@ default GenericElement clear() {
      * @since 2.0
      */
     default <T extends PageFragment> T as(Class<T> fragmentClass) {
-        return new PageFragmentFactory(getBrowser()).pageFragment(fragmentClass, webElement());
+        return new PageFragmentFactory(browser()).pageFragment(fragmentClass, webElement());
     }
 
 }

webtester-core/src/main/java/info/novatec/testit/webtester/pagefragments/PageFragment.java

@@ -153,7 +153,7 @@ default Optional<String> getAttribute(String attributeName) {
     default void setAttribute(String attributeName, String value) {
         String escapedValue = StringUtils.replace(value, "\"", "\\\"");
         String script = "arguments[0]." + attributeName + " = \"" + escapedValue + "\"";
-        getBrowser().javaScript().execute(script, this, value);
+        browser().javaScript().execute(script, this, value);
     }
 
     /**

webtester-core/src/main/java/info/novatec/testit/webtester/pages/Page.java

@@ -71,7 +71,7 @@ public interface Page extends OffersBrowserGetter, OffersPageCreation, OffersAdH
 
     @Override
     default AdHocFinder finder() {
-        return new AdHocFinder(getBrowser());
+        return new AdHocFinder(browser());
     }
 
 }

webtester-core/src/main/java/info/novatec/testit/webtester/waiting/WaitConfig.java

@@ -61,7 +61,7 @@ public long getTimeoutInMillis() {
      * @since 2.0
      */
     static WaitConfig from(PageFragment fragment) {
-        return from(fragment.getBrowser());
+        return from(fragment.browser());
     }
 
     /**

webtester-core/src/test/java/info/novatec/testit/webtester/css/DefaultStyleChangerTest.java

@@ -38,7 +38,7 @@ public class DefaultStyleChangerTest {
 
     @Before
     public void init() {
-        doReturn(browser).when(fragment).getBrowser();
+        doReturn(browser).when(fragment).browser();
         doReturn(javaScript).when(browser).javaScript();
     }
 

webtester-core/src/test/java/info/novatec/testit/webtester/markings/MarkerTest.java

@@ -47,7 +47,7 @@ private static abstract class AbstractMarkerTest {
 
         @Before
         public void configuration() {
-            when(fragment.getBrowser().configuration()).thenReturn(configuration);
+            when(fragment.browser().configuration()).thenReturn(configuration);
         }
 
     }

webtester-core/src/test/java/info/novatec/testit/webtester/waiting/WaitConfigTest.java

@@ -114,7 +114,7 @@ public void canBeCreatedFromBrowser() {
         @Test
         public void canBeCreatedFromPageFragment() {
 
-            doReturn(browser).when(pageFragment).getBrowser();
+            doReturn(browser).when(pageFragment).browser();
             doReturn(configuration).when(browser).configuration();
             doReturn(3).when(configuration).getWaitTimeout();
             doReturn(30L).when(configuration).getWaitInterval();

webtester-core/src/test/java/info/novatec/testit/webtester/waiting/WaitTest.java

@@ -118,7 +118,7 @@ public static class Until_PageFragment extends AbstractWaitTest {
         @Before
         public void setUpFragment() {
             doReturn(configuration).when(browser).configuration();
-            doReturn(browser).when(fragment).getBrowser();
+            doReturn(browser).when(fragment).browser();
             doReturn(1).when(configuration).getWaitTimeout();
             doReturn(50L).when(configuration).getWaitInterval();
         }