Added missing tests for conditions packages based on PITest

Author: slu-it

webtester-core/src/main/java/info/novatec/testit/webtester/browser/operations/JavaScriptExecutor.java

@@ -49,6 +49,7 @@ public void execute(String script, PageFragment fragment, Object... parameters)
      * @param script the JavaScript code to be executed on the current page
      * @param fragment the target {@link PageFragment}
      * @param parameters any of Boolean, Long, String, List, WebElement or null.
+     * @param <T> the type of the return value is cast to before returning
      * @return the return value of the JavaScript
      * @see JavascriptExecutor#executeScript(String, Object...)
      * @since 2.0
@@ -79,6 +80,7 @@ public void execute(String script, Object... parameters) {
      *
      * @param script the JavaScript code to be executed on the current page
      * @param parameters any of Boolean, Long, String, List, WebElement or null.
+     * @param <T> the type of the return value is cast to before returning
      * @return the return value of the JavaScript
      * @see JavascriptExecutor#executeScript(String, Object...)
      * @since 2.0

webtester-core/src/main/java/info/novatec/testit/webtester/conditions/pagefragments/ReadOnly.java

@@ -33,7 +33,7 @@ private boolean isXhtmlReadOnly(String value) {
 
     @Override
     public String toString() {
-        return "read-only";
+        return "read only";
     }
 
 }

webtester-core/src/main/java/info/novatec/testit/webtester/conditions/pagefragments/SelectedTexts.java

@@ -2,9 +2,8 @@
 
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.HashSet;
-import java.util.Set;
-import java.util.stream.Collectors;
+import java.util.LinkedList;
+import java.util.List;
 
 import org.apache.commons.lang.StringUtils;
 
@@ -23,7 +22,7 @@
  */
 public class SelectedTexts implements Condition<MultiSelect> {
 
-    private final Set<String> expectedTexts = new HashSet<>();
+    private final List<String> expectedTexts = new LinkedList<>();
 
     public SelectedTexts(String text) {
         this.expectedTexts.add(text);
@@ -39,7 +38,8 @@ public SelectedTexts(Collection<String> texts) {
 
     @Override
     public boolean test(MultiSelect select) {
-        return expectedTexts.equals(select.streamSelectionTexts().collect(Collectors.toSet()));
+        List<String> selectionTexts = select.getSelectionTexts();
+        return expectedTexts.containsAll(selectionTexts) && selectionTexts.containsAll(expectedTexts);
     }
 
     @Override

webtester-core/src/main/java/info/novatec/testit/webtester/conditions/pagefragments/SelectedValues.java

@@ -2,9 +2,8 @@
 
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.HashSet;
-import java.util.Set;
-import java.util.stream.Collectors;
+import java.util.LinkedList;
+import java.util.List;
 
 import org.apache.commons.lang.StringUtils;
 
@@ -23,7 +22,7 @@
  */
 public class SelectedValues implements Condition<MultiSelect> {
 
-    private final Set<String> expectedValues = new HashSet<>();
+    private final List<String> expectedValues = new LinkedList<>();
 
     public SelectedValues(String value) {
         this.expectedValues.add(value);
@@ -39,7 +38,8 @@ public SelectedValues(Collection<String> values) {
 
     @Override
     public boolean test(MultiSelect select) {
-        return expectedValues.equals(select.streamSelectionValues().collect(Collectors.toSet()));
+        List<String> selectionValues = select.getSelectionValues();
+        return expectedValues.containsAll(selectionValues) && selectionValues.containsAll(expectedValues);
     }
 
     @Override

webtester-core/src/main/java/info/novatec/testit/webtester/waiting/ConfiguredWait.java

@@ -44,6 +44,7 @@ public ConfiguredWait(long timeout, TimeUnit timeUnit) {
      * {@link PageFragment}.
      *
      * @param fragment the fragment for the wait until operation
+     * @param <T> the type of the page fragment subclass
      * @return the fluent wait instance
      * @see Wait
      * @see WaitUntil

webtester-core/src/main/java/info/novatec/testit/webtester/waiting/Wait.java

@@ -59,6 +59,7 @@ public static ConfiguredWait withTimeoutOf(long timeout, TimeUnit timeUnit) {
      * {@link PageFragment fragment} was created in.
      *
      * @param fragment the fragment for the wait until operation
+     * @param <T> the type of the page fragment subclass
      * @return the fluent wait instance
      * @see Wait
      * @see WaitUntil

webtester-core/src/test/java/info/novatec/testit/webtester/conditions/pagefragments/AttributeTest.java

@@ -10,22 +10,23 @@
 
 public class AttributeTest {
 
-    Attribute cut = new Attribute("attribute");
+    Attribute cut = new Attribute("type");
 
     @Test
     public void havingTheAttributeEvaluatesToTrue() {
-        PageFragment fragment = fragment().withAttribute("attribute").build();
-        assertThat(hasAttribute(fragment)).isTrue();
+        PageFragment fragment = fragment().withAttribute("type").build();
+        assertThat(cut.test(fragment)).isTrue();
     }
 
     @Test
     public void notHavingTheAttributeEvaluatesToFalse() {
-        PageFragment fragment = fragment().withoutAttribute("attribute").build();
-        assertThat(hasAttribute(fragment)).isFalse();
+        PageFragment fragment = fragment().withoutAttribute("type").build();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
-    boolean hasAttribute(PageFragment fragment) {
-        return cut.test(fragment);
+    @Test
+    public void toStringIsGeneratedCorrectly() {
+        assertThat(cut).hasToString("attribute 'type'");
     }
 
 }

webtester-core/src/test/java/info/novatec/testit/webtester/conditions/pagefragments/AttributeWithValueTest.java

@@ -10,28 +10,29 @@
 
 public class AttributeWithValueTest {
 
-    AttributeWithValue cut = new AttributeWithValue("attribute", "value");
+    AttributeWithValue cut = new AttributeWithValue("type", "text");
 
     @Test
     public void havingTheAttributeValueMatchEvaluatesToTrue() {
-        PageFragment fragment = fragment().withAttribute("attribute", "value").build();
-        assertThat(hasAttributeWithValue(fragment)).isTrue();
+        PageFragment fragment = fragment().withAttribute("type", "text").build();
+        assertThat(cut.test(fragment)).isTrue();
     }
 
     @Test
     public void havingADifferentValueForTheAttributeEvaluatesToFalse() {
-        PageFragment fragment = fragment().withAttribute("attribute", "otherValue").build();
-        assertThat(hasAttributeWithValue(fragment)).isFalse();
+        PageFragment fragment = fragment().withAttribute("type", "password").build();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
     @Test
     public void notHavingTheAttributeEvaluatesToFalse() {
-        PageFragment fragment = fragment().withoutAttribute("attribute").build();
-        assertThat(hasAttributeWithValue(fragment)).isFalse();
+        PageFragment fragment = fragment().withoutAttribute("type").build();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
-    boolean hasAttributeWithValue(PageFragment fragment) {
-        return cut.test(fragment);
+    @Test
+    public void toStringIsGeneratedCorrectly() {
+        assertThat(cut).hasToString("attribute 'type' with value 'text'");
     }
 
 }

webtester-core/src/test/java/info/novatec/testit/webtester/conditions/pagefragments/DisabledTest.java

@@ -15,17 +15,18 @@ public class DisabledTest {
     @Test
     public void disabledPageFragmentEvaluatesToTrue() {
         PageFragment fragment = fragment().disabled().build();
-        assertThat(isDisabled(fragment)).isTrue();
+        assertThat(cut.test(fragment)).isTrue();
     }
 
     @Test
     public void enabledPageFragmentEvaluatesToFalse() {
         PageFragment fragment = fragment().enabled().build();
-        assertThat(isDisabled(fragment)).isFalse();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
-    boolean isDisabled(PageFragment fragment) {
-        return cut.test(fragment);
+    @Test
+    public void toStringIsGeneratedCorrectly() {
+        assertThat(cut).hasToString("disabled");
     }
 
 }

webtester-core/src/test/java/info/novatec/testit/webtester/conditions/pagefragments/EditableTest.java

@@ -20,7 +20,7 @@ public void presentVisibleEnabledAndWritablePageFragmentIsEditable() {
             .enabled()
             .writable()
             .build();
-        assertThat(isEditable(fragment)).isTrue();
+        assertThat(cut.test(fragment)).isTrue();
     }
 
     @Test
@@ -31,7 +31,7 @@ public void notPresentVisibleEnabledAndWritablePageFragmentIsNotEditable() {
             .enabled()
             .writable()
             .build();
-        assertThat(isEditable(fragment)).isFalse();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
     @Test
@@ -42,7 +42,7 @@ public void presentInvisibleEnabledAndWritablePageFragmentINotEditable() {
             .enabled()
             .writable()
             .build();
-        assertThat(isEditable(fragment)).isFalse();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
     @Test
@@ -53,7 +53,7 @@ public void presentVisibleDisabledAndWritablePageFragmentIsNotEditable() {
             .disabled()
             .writable()
             .build();
-        assertThat(isEditable(fragment)).isFalse();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
     @Test
@@ -64,11 +64,12 @@ public void presentVisibleEnabledAndReadOnlyPageFragmentIsNotEditable() {
             .enabled()
             .readOnly()
             .build();
-        assertThat(isEditable(fragment)).isFalse();
+        assertThat(cut.test(fragment)).isFalse();
     }
 
-    boolean isEditable(PageFragment fragment) {
-        return cut.test(fragment);
+    @Test
+    public void toStringIsGeneratedCorrectly() {
+        assertThat(cut).hasToString("editable");
     }
 
 }