Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Commit 602c6bd

Browse files
slu-itslu-it
committed
Made all selenium and support module dependencies "provided" in order to shift the responsibility of version definition to the host project
1 parent 704ed34 commit 602c6bd

File tree

9 files changed

+62
-19
lines changed

9 files changed

+62
-19
lines changed

‎webtester-core/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,10 @@
4444
</dependency>
4545

4646
<dependency>
47-
<!-- Selenium dependency used to have access to the Selenium API. -->
47+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
4848
<groupId>org.seleniumhq.selenium</groupId>
4949
<artifactId>selenium-support</artifactId>
50+
<scope>provided</scope>
5051
</dependency>
5152

5253
<!-- test -->

‎webtester-support-assertj3/pom.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,18 @@
2424
<version>${project.version}</version>
2525
</dependency>
2626
<dependency>
27-
<!-- Optional dependency on assertj-core. Projects using this module should
27+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
28+
<groupId>org.seleniumhq.selenium</groupId>
29+
<artifactId>selenium-support</artifactId>
30+
<scope>provided</scope>
31+
</dependency>
32+
<dependency>
33+
<!-- Provided dependency on assertj-core. Projects using this module should
2834
provide their own version of the assertj dependency and not be forced to
2935
inherit this one! -->
3036
<groupId>org.assertj</groupId>
3137
<artifactId>assertj-core</artifactId>
32-
<optional>true</optional>
38+
<scope>provided</scope>
3339
</dependency>
3440
<dependency>
3541
<!-- Test dependency on webtester-core in order to access test utility classes. -->

‎webtester-support-assertj3/src/license/THIRD-PARTY.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
# - Apache License, Version 2.0
66
# - LGPL, version 2.1
77
# - MIT License
8-
# - NovaTec testIT License
8+
# - The Apache License, Version 2.0
99
# - The Apache Software License, Version 2.0
1010
#-------------------------------------------------------------------------------
1111
# Please fill the missing licenses for dependencies :
1212
#
1313
#
14-
#Mon Nov 09 10:02:53 CET 2015
14+
#Fri May 13 18:07:45 CEST 2016
1515
cglib--cglib-nodep--2.1_3=The Apache Software License, Version 2.0

‎webtester-support-chrome/pom.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,19 @@
2525
</dependency>
2626

2727
<dependency>
28-
<!-- Required dependency on selenium-chrome-drive used to interact with
28+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
29+
<groupId>org.seleniumhq.selenium</groupId>
30+
<artifactId>selenium-support</artifactId>
31+
<scope>provided</scope>
32+
</dependency>
33+
<dependency>
34+
<!-- Provided dependency on selenium-chrome-drive used to interact with
2935
a Chrome browser. The dependency should be inherited by projects using this
3036
module. If another version of this dependency is needed / wanted it should
3137
be overridden by the project. -->
3238
<groupId>org.seleniumhq.selenium</groupId>
3339
<artifactId>selenium-chrome-driver</artifactId>
40+
<scope>provided</scope>
3441
</dependency>
3542

3643
</dependencies>

‎webtester-support-firefox/pom.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,19 @@
2525
</dependency>
2626

2727
<dependency>
28-
<!-- Required dependency on selenium-firefox-driver used to interact with
28+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
29+
<groupId>org.seleniumhq.selenium</groupId>
30+
<artifactId>selenium-support</artifactId>
31+
<scope>provided</scope>
32+
</dependency>
33+
<dependency>
34+
<!-- Provided dependency on selenium-firefox-driver used to interact with
2935
a Firefox browser. The dependency should be inherited by projects using this
3036
module. If another version of this dependency is needed / wanted it should
3137
be overridden by the project. -->
3238
<groupId>org.seleniumhq.selenium</groupId>
3339
<artifactId>selenium-firefox-driver</artifactId>
40+
<scope>provided</scope>
3441
</dependency>
3542

3643
</dependencies>

‎webtester-support-hamcrest/pom.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,18 @@
2525
<version>${project.version}</version>
2626
</dependency>
2727
<dependency>
28-
<!-- Optional dependency on hamcrest-all. Projects using this module should
28+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
29+
<groupId>org.seleniumhq.selenium</groupId>
30+
<artifactId>selenium-support</artifactId>
31+
<scope>provided</scope>
32+
</dependency>
33+
<dependency>
34+
<!-- Provided dependency on hamcrest-all. Projects using this module should
2935
provide their own version of the hamcrest dependency and not be forced
3036
to inherit this one! -->
3137
<groupId>org.hamcrest</groupId>
3238
<artifactId>hamcrest-all</artifactId>
33-
<optional>true</optional>
39+
<scope>provided</scope>
3440
</dependency>
3541
<dependency>
3642
<!-- Test dependency on webtester-core in order to access test utility classes. -->

‎webtester-support-ie/pom.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,20 @@
2323
<artifactId>webtester-core</artifactId>
2424
<version>${project.version}</version>
2525
</dependency>
26-
2726
<dependency>
28-
<!-- Required dependency on selenium-ie-driver used to interact with an
27+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
28+
<groupId>org.seleniumhq.selenium</groupId>
29+
<artifactId>selenium-support</artifactId>
30+
<scope>provided</scope>
31+
</dependency>
32+
<dependency>
33+
<!-- Provided dependency on selenium-ie-driver used to interact with an
2934
Internet Explorer browser. The dependency should be inherited by projects
3035
using this module. If another version of this dependency is needed / wanted
3136
it should be overridden by the project. -->
3237
<groupId>org.seleniumhq.selenium</groupId>
3338
<artifactId>selenium-ie-driver</artifactId>
39+
<scope>provided</scope>
3440
</dependency>
3541

3642
</dependencies>

‎webtester-support-junit4/pom.xml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,19 @@
2323
<artifactId>webtester-core</artifactId>
2424
<version>${project.version}</version>
2525
</dependency>
26-
2726
<dependency>
28-
<!-- Optional dependency on junit. Projects using this module should provide
27+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
28+
<groupId>org.seleniumhq.selenium</groupId>
29+
<artifactId>selenium-support</artifactId>
30+
<scope>provided</scope>
31+
</dependency>
32+
<dependency>
33+
<!-- Provided dependency on junit. Projects using this module should provide
2934
their own version of the junit dependency and not be forced to inherit this
3035
one! -->
3136
<groupId>junit</groupId>
3237
<artifactId>junit</artifactId>
33-
<optional>true</optional>
38+
<scope>provided</scope>
3439
</dependency>
3540

3641
</dependencies>

‎webtester-support-spring4/pom.xml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,27 @@
2828
<artifactId>webtester-core</artifactId>
2929
<version>${project.version}</version>
3030
</dependency>
31-
3231
<dependency>
33-
<!-- Optional dependency on spring-core. Projects using this module should
32+
<!-- Provided Selenium dependency used to have access to the Selenium API. -->
33+
<groupId>org.seleniumhq.selenium</groupId>
34+
<artifactId>selenium-support</artifactId>
35+
<scope>provided</scope>
36+
</dependency>
37+
<dependency>
38+
<!-- Provided dependency on spring-core. Projects using this module should
3439
provide their own version of the spring-core dependency and not be forced
3540
to inherit this one! -->
3641
<groupId>org.springframework</groupId>
3742
<artifactId>spring-core</artifactId>
38-
<optional>true</optional>
43+
<scope>provided</scope>
3944
</dependency>
4045
<dependency>
41-
<!-- Optional dependency on spring-context. Projects using this module
46+
<!-- Provided dependency on spring-context. Projects using this module
4247
should provide their own version of the spring-context dependency and not
4348
be forced to inherit this one! -->
4449
<groupId>org.springframework</groupId>
4550
<artifactId>spring-context</artifactId>
46-
<optional>true</optional>
51+
<scope>provided</scope>
4752
</dependency>
4853

4954
<!-- The following dependencies are only used by tests of this module and

0 commit comments

Comments
 (0)