Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Commit 43c9f8a

Browse files
committed
fixed issue with certain browsers, when defining no proxy configuration
1 parent c85f38f commit 43c9f8a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

webtester-core/src/main/java/info/novatec/testit/webtester/browser/factories/BaseBrowserFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import info.novatec.testit.webtester.browser.Browser;
1111
import info.novatec.testit.webtester.browser.BrowserFactory;
1212
import info.novatec.testit.webtester.browser.WebDriverBrowser;
13+
import info.novatec.testit.webtester.browser.proxy.NoProxyConfiguration;
1314
import info.novatec.testit.webtester.browser.proxy.ProxyConfiguration;
1415

1516

@@ -61,7 +62,7 @@ public Browser createBrowser(WebDriver webDriver) {
6162
}
6263

6364
protected void setOptionalProxyConfiguration(DesiredCapabilities capabilities) {
64-
if (proxyConfiguration != null) {
65+
if (proxyConfiguration != null && !(proxyConfiguration instanceof NoProxyConfiguration)) {
6566
Proxy proxy = new Proxy();
6667
proxyConfiguration.configureProxy(proxy);
6768
capabilities.setCapability(CapabilityType.PROXY, proxy);

0 commit comments

Comments
 (0)