Removed @cached annotation and the complete caching feature

Caching added an unnecessary overhead of complexity to the framework which in the end didn't help as much as expected.
The number of milliseconds saved by the feature were minimal and in some cases the caching itself became an overhead.
Always resolving the WebElement anew is the way to go.

Author: slu-it

documentation/README.md

@@ -11,7 +11,6 @@
 - Annotations
   - [@Action](chapters/annotation-action.md)
   - [@Attribute](chapters/annotation-attribute.md)
-  - [@Cached](chapters/annotation-cached.md)
   - [@IdentifyUsing](chapters/annotation-identify-using.md)
   - [@Mark](chapters/annotation-mark.md)
   - [@Named](chapters/annotation-named.md)

documentation/chapters/annotation-cached.md

@@ -80,10 +80,6 @@ The following shows all default properties loaded by the `DefaultFileConfigurati
 The values are the same as the fallback values of the `BaseConfiguration` implementation.
 
 ```properties
-# Weather or not caches (i.e. of web elements) should be enabled by default.
-# TYPE: boolean [true, false]
-caches.enabled = false
-
 # Weather or not the events should be fired.
 # TYPE: boolean [true, false]
 events.enabled = true

documentation/chapters/configuration.md

@@ -90,7 +90,6 @@ These annotations can be used within a `PageFragment`.
 
 - [@Action](annotation-action.md)
 - [@Attribute](annotation-attribute.md)
-- [@Cached](annotation-cached.md)
 - [@IdentifyUsing](annotation-identify-using.md)
 - [@Mark](annotation-mark.md)
 - [@Named](annotation-named.md)

documentation/chapters/page-fragment.md

@@ -93,7 +93,6 @@ public interface CollectionPage extends Page {
 These annotations can be used within a `Page`.
 
 - [@Action](annotation-action.md)
-- [@Cached](annotation-cached.md)
 - [@IdentifyUsing](annotation-identify-using.md)
 - [@Named](annotation-named.md)
 - [@PostConstruct](annotation-post-construct.md)

documentation/chapters/page.md

@@ -52,16 +52,6 @@ public class BaseConfiguration implements Configuration {
 
     /* named properties */
 
-    @Override
-    public boolean isCachingEnabled() {
-        return getBooleanProperty(key(NamedProperties.CACHES), Boolean.FALSE);
-    }
-
-    @Override
-    public Configuration setCaching(boolean active) {
-        return setProperty(key(NamedProperties.CACHES), active);
-    }
-
     @Override
     public long getActionDeceleration() {
         return getLongProperty(key(NamedProperties.ACTIONS_DECELERATION), 0L);

webtester-core/src/main/java/info/novatec/testit/webtester/config/BaseConfiguration.java

@@ -11,7 +11,6 @@
 import info.novatec.testit.webtester.events.Event;
 import info.novatec.testit.webtester.events.EventSystem;
 import info.novatec.testit.webtester.pagefragments.annotations.Action;
-import info.novatec.testit.webtester.pagefragments.annotations.Cached;
 import info.novatec.testit.webtester.waiting.Wait;
 
 
@@ -39,25 +38,6 @@
  */
 public interface Configuration {
 
-    /**
-     * Returns whether or not caching mechanisms are globally enabled.
-     *
-     * @return true if caching is enabled by default
-     * @see Cached
-     * @since 2.0
-     */
-    boolean isCachingEnabled();
-
-    /**
-     * Set whether or not caching mechanisms are globally enabled.
-     *
-     * @param active true if caching should be enabled by default
-     * @return the same instance for fluent API use
-     * @see Cached
-     * @since 2.0
-     */
-    Configuration setCaching(boolean active);
-
     /**
      * Returns the number of milliseconds actions should be decelerated.
      * Actions are methods annotated with {@link Action @Action}.

webtester-core/src/main/java/info/novatec/testit/webtester/config/Configuration.java

@@ -5,13 +5,11 @@
 import java.util.function.Consumer;
 import java.util.function.Function;
 
-import org.openqa.selenium.StaleElementReferenceException;
-
 import info.novatec.testit.webtester.browser.Browser;
 import info.novatec.testit.webtester.events.Event;
 import info.novatec.testit.webtester.events.EventSystem;
-import info.novatec.testit.webtester.pagefragments.PageFragment;
 import info.novatec.testit.webtester.markings.Marker;
+import info.novatec.testit.webtester.pagefragments.PageFragment;
 
 
 public final class ActionTemplate {
@@ -42,16 +40,11 @@ public Action(T subject, Browser browser) {
             this.browser = browser;
         }
 
-        @SuppressWarnings({"unchecked", "PMD.AvoidCatchingGenericException"})
+        @SuppressWarnings({ "unchecked", "PMD.AvoidCatchingGenericException" })
         public A execute(Consumer<T> consumer) {
             try {
-                try {
-                    consumer.accept(subject);
-                } catch (StaleElementReferenceException e) {
-                    WebElementFinder.clearCache();
-                    consumer.accept(subject);
-                }
-            } catch (RuntimeException e){
+                consumer.accept(subject);
+            } catch (RuntimeException e) {
                 browser.events().fireExceptionEvent(e);
                 throw e;
             }
@@ -80,16 +73,11 @@ public BiAction(T subject1, T subject2, Browser browser) {
             this.browser = browser;
         }
 
-        @SuppressWarnings({"unchecked", "PMD.AvoidCatchingGenericException"})
+        @SuppressWarnings({ "unchecked", "PMD.AvoidCatchingGenericException" })
         public A execute(BiConsumer<T, T> consumer) {
             try {
-                try {
-                    consumer.accept(subject1, subject2);
-                } catch (StaleElementReferenceException e) {
-                    WebElementFinder.clearCache();
-                    consumer.accept(subject1, subject2);
-                }
-            } catch (RuntimeException e){
+                consumer.accept(subject1, subject2);
+            } catch (RuntimeException e) {
                 browser.events().fireExceptionEvent(e);
                 throw e;
             }
@@ -118,7 +106,7 @@ public PageFragmentAction(T subject) {
 
         public PageFragmentAction<T> fireEvent(Function<T, Event> function) {
             EventSystem eventSystem = getEventSystem();
-            if(eventSystem.isEnabled()) {
+            if (eventSystem.isEnabled()) {
                 eventSystem.fireEvent(function.apply(getSubject()));
             }
             return this;
@@ -144,7 +132,7 @@ public PageFragmentsAction(T subject1, T subject2) {
 
         public PageFragmentsAction<T> fireEvent(BiFunction<T, T, Event> function) {
             EventSystem eventSystem = getEventSystem();
-            if(eventSystem.isEnabled()) {
+            if (eventSystem.isEnabled()) {
                 eventSystem.fireEvent(function.apply(getSubject1(), getSubject2()));
             }
             return this;
@@ -172,7 +160,7 @@ public BrowserAction(T subject) {
 
         public BrowserAction<T> fireEvent(Function<T, Event> function) {
             EventSystem eventSystem = getEventSystem();
-            if(eventSystem.isEnabled()) {
+            if (eventSystem.isEnabled()) {
                 eventSystem.fireEvent(function.apply(getSubject()));
             }
             return this;