Refactored tests of browser operations to be truly isolated from outside influences

Author: slu-it

webtester-core/src/main/java/info/novatec/testit/webtester/browser/operations/FocusSetter.java

@@ -51,8 +51,8 @@ public void onFrame(int index) throws NoSuchFrameException {
         log.debug("focused on frame with index: {}", index);
     }
 
-    private WebDriver doOnFrame(Browser browser, int index) {
-        return browser.webDriver().switchTo().frame(index);
+    private void doOnFrame(Browser browser, int index) {
+        browser.webDriver().switchTo().frame(index);
     }
 
     /**
@@ -70,8 +70,8 @@ public void onFrame(String nameOrId) throws NoSuchFrameException {
         log.debug("focused on frame with name or ID: {}", nameOrId);
     }
 
-    private WebDriver doOnFrame(Browser browser, String nameOrId) {
-        return browser.webDriver().switchTo().frame(nameOrId);
+    private void doOnFrame(Browser browser, String nameOrId) {
+        browser.webDriver().switchTo().frame(nameOrId);
     }
 
     /**
@@ -89,8 +89,8 @@ public void onFrame(PageFragment frame) throws NoSuchFrameException {
         log.debug("focused on frame page fragment: {}", frame);
     }
 
-    private WebDriver doOnFrame(Browser browser, PageFragment frame) {
-        return browser.webDriver().switchTo().frame(frame.webElement());
+    private void doOnFrame(Browser browser, PageFragment frame) {
+        browser.webDriver().switchTo().frame(frame.webElement());
     }
 
     /**

webtester-core/src/test/java/info/novatec/testit/webtester/browser/WebDriverBrowserTest.java

@@ -199,6 +199,13 @@ public void openingAnUrlInvokesTheOpenUrlOperationClass() {
             verify(open).url("http://www.foo.com");
         }
 
+        @Test
+        public void openingAnUrlReturnsSameBrowser() {
+            TestUtils.setFieldValue(browser, "open", open);
+            Browser returnedBrowser = this.browser.open("http://www.foo.com");
+            assertThat(returnedBrowser).isSameAs(browser);
+        }
+
     }
 
     public static class FactoryAndBuilder {

webtester-core/src/test/java/info/novatec/testit/webtester/browser/operations/AlertHandlerTest.java

@@ -1,6 +1,7 @@
 package info.novatec.testit.webtester.browser.operations;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -12,6 +13,7 @@
 import org.mockito.Answers;
 import org.mockito.ArgumentCaptor;
 import org.mockito.Captor;
+import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.runners.MockitoJUnitRunner;
 import org.openqa.selenium.Alert;
@@ -20,10 +22,7 @@
 import org.openqa.selenium.security.Credentials;
 import org.openqa.selenium.security.UserAndPassword;
 
-import utils.events.EventCaptor;
-
 import info.novatec.testit.webtester.browser.Browser;
-import info.novatec.testit.webtester.browser.WebDriverBrowser;
 import info.novatec.testit.webtester.events.EventSystem;
 import info.novatec.testit.webtester.events.browser.AcceptedAlertEvent;
 import info.novatec.testit.webtester.events.browser.DeclinedAlertEvent;
@@ -37,16 +36,19 @@ static abstract class AbstractAlertHandlerTest {
 
         @Mock(answer = Answers.RETURNS_DEEP_STUBS)
         WebDriver webDriver;
-
+        @Mock
+        EventSystem events;
+        @Mock
         Browser browser;
-        EventSystem eventSystem;
+
+        @InjectMocks
         AlertHandler cut;
 
         @Before
-        public void initializeClassUnderTest() {
-            browser = WebDriverBrowser.forWebDriver(webDriver).build();
-            eventSystem = browser.events();
-            cut = new AlertHandler(browser);
+        public void init() {
+            doReturn(webDriver).when(browser).webDriver();
+            doReturn(events).when(browser).events();
+            doReturn(true).when(events).isEnabled();
         }
 
         Alert alertIsPresent(String message) {
@@ -65,6 +67,9 @@ void alertIsNotPresent() {
 
     public static class Accept extends AbstractAlertHandlerTest {
 
+        @Captor
+        ArgumentCaptor<AcceptedAlertEvent> eventCaptor;
+
         @Test
         public void alertsCanBeAccepted() {
             Alert alert = alertIsPresent("hello alert!");
@@ -81,16 +86,19 @@ public void acceptingNonExistentAlertThrowsException() {
         @Test
         public void acceptingAnAlertFiresEvent() {
             alertIsPresent("hello alert!");
-            EventCaptor.capture(eventSystem, AcceptedAlertEvent.class)
-                .execute(() -> cut.accept())
-                .assertEventWasFired()
-                .assertEvent(event -> assertThat(event.getAlertMessage()).isEqualTo("hello alert!"));
+            cut.accept();
+            verify(events).fireEvent(eventCaptor.capture());
+            AcceptedAlertEvent event = eventCaptor.getValue();
+            assertThat(event.getAlertMessage()).isEqualTo("hello alert!");
         }
 
     }
 
     public static class AcceptIfPresent extends AbstractAlertHandlerTest {
 
+        @Captor
+        ArgumentCaptor<AcceptedAlertEvent> eventCaptor;
+
         @Test
         public void alertsCanBeAcceptedIfTheyArePresent() {
             Alert alert = alertIsPresent("hello alert!");
@@ -105,10 +113,22 @@ public void acceptingAnAlertIfItsPresentDoesNotThrowExceptionIfNoAlertExists() {
             // no exception
         }
 
+        @Test
+        public void acceptingAnAlertFiresEvent() {
+            alertIsPresent("hello alert!");
+            cut.acceptIfPresent();
+            verify(events).fireEvent(eventCaptor.capture());
+            AcceptedAlertEvent event = eventCaptor.getValue();
+            assertThat(event.getAlertMessage()).isEqualTo("hello alert!");
+        }
+
     }
 
     public static class Decline extends AbstractAlertHandlerTest {
 
+        @Captor
+        ArgumentCaptor<DeclinedAlertEvent> eventCaptor;
+
         @Test
         public void alertsCanBeDeclined() {
             Alert alert = alertIsPresent("hello alert!");
@@ -125,16 +145,19 @@ public void decliningNonExistentAlertThrowsException() {
         @Test
         public void decliningAnAlertFiresEvent() {
             alertIsPresent("hello alert!");
-            EventCaptor.capture(eventSystem, DeclinedAlertEvent.class)
-                .execute(() -> cut.decline())
-                .assertEventWasFired()
-                .assertEvent(event -> assertThat(event.getAlertMessage()).isEqualTo("hello alert!"));
+            cut.decline();
+            verify(events).fireEvent(eventCaptor.capture());
+            DeclinedAlertEvent event = eventCaptor.getValue();
+            assertThat(event.getAlertMessage()).isEqualTo("hello alert!");
         }
 
     }
 
     public static class DeclineIfPresent extends AbstractAlertHandlerTest {
 
+        @Captor
+        ArgumentCaptor<DeclinedAlertEvent> eventCaptor;
+
         @Test
         public void alertsCanBeDeclinedIfTheyArePresent() {
             Alert alert = alertIsPresent("hello alert!");
@@ -149,6 +172,15 @@ public void decliningAnAlertIfItsPresentDoesNotThrowExceptionIfNoAlertExists() {
             // no exception
         }
 
+        @Test
+        public void decliningAnAlertFiresEvent() {
+            alertIsPresent("hello alert!");
+            cut.declineIfPresent();
+            verify(events).fireEvent(eventCaptor.capture());
+            DeclinedAlertEvent event = eventCaptor.getValue();
+            assertThat(event.getAlertMessage()).isEqualTo("hello alert!");
+        }
+
     }
 
     public static class IsPresent extends AbstractAlertHandlerTest {
@@ -193,7 +225,7 @@ public void canAuthenticateWithCredentials() {
 
             Alert alert = alertIsPresent("please sign in");
             Credentials credentials = new UserAndPassword("foo", "bar");
-            browser.alert().authenticateWith(credentials);
+            cut.authenticateWith(credentials);
 
             verify(alert).authenticateUsing(credentials);
 
@@ -203,7 +235,7 @@ public void canAuthenticateWithCredentials() {
         public void canAuthenticateWithUsernameAndPassword() {
 
             Alert alert = alertIsPresent("please sign in");
-            browser.alert().authenticateWith("foo", "bar");
+            cut.authenticateWith("foo", "bar");
             verify(alert).authenticateUsing(credentialsCaptor.capture());
 
             Credentials credentials = credentialsCaptor.getValue();